Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linestring geometryIndexes() & geometryGeojson() #6

Open
morganherlocker opened this issue Jul 24, 2014 · 2 comments
Open

linestring geometryIndexes() & geometryGeojson() #6

morganherlocker opened this issue Jul 24, 2014 · 2 comments

Comments

@morganherlocker
Copy link
Contributor

No description provided.

@morganherlocker morganherlocker mentioned this issue Jul 24, 2014
Closed
@morganherlocker
Copy link
Contributor Author

I have added support for more efficient linestring indexing. Instead of running a linestring as a polygon (s2map), or as a bbox (current cardboard), linestrings are now given a slight buffer (.00001 miles), then run as a polygon. Computation of a line buffer is not the cheapest in node, but probably way cheaper down the pipe than our lines requiring more GETs. In the future, we could do this directly in s2/C++ for more speed. Results:

Input:
img

s2Map Output:
img

geojson-cover Output:

img

@tmcw
Copy link
Contributor

tmcw commented Aug 5, 2014

Awesome, nice work. Happened in 00679b7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmcw @morganherlocker