Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zaptec an official HA integration? #129

Open
sveinse opened this issue Oct 19, 2024 · 6 comments
Open

Make zaptec an official HA integration? #129

sveinse opened this issue Oct 19, 2024 · 6 comments
Labels
question Further information is requested

Comments

@sveinse
Copy link
Collaborator

sveinse commented Oct 19, 2024

Currently the zaptec integration is distributed via the HACS framework.

Would it be interesting to have zaptec as an official HA integration? I'd like to hear from the people that are using the integration. Migrating the zaptec integration from a HACS installable integration into a official HA integration will require considerable efforts. There is no point in doing it unless there is a need and would benefit our users.

What do you think? Is using HACS for this repo a burden for making use of zaptec?

@sveinse sveinse added the question Further information is requested label Oct 19, 2024
@c0mplex1
Copy link
Contributor

For me personally it is not really an extra burden to use Zaptec integration via HACS, but I think that if the integration becomes part of HA OS it will work even more reliably than it is now. After all, your integration does not need HACS anymore.

@dsmagghe
Copy link

would be nice, but even nicer if the load balancer would also be able to balance multiple chargers at once. I see the last commit there was more then 9 months ago :(

@Ghannes
Copy link

Ghannes commented Oct 30, 2024

Currently the zaptec integration is distributed via the HACS framework.

Would it be interesting to have zaptec as an official HA integration? I'd like to hear from the people that are using the integration. Migrating the zaptec integration from a HACS installable integration into a official HA integration will require considerable efforts. There is no point in doing it unless there is a need and would benefit our users.

What do you think? Is using HACS for this repo a burden for making use of zaptec?

What are the addiotional efforts?

@sveinse
Copy link
Collaborator Author

sveinse commented Oct 30, 2024

What are the addiotional efforts?

  • The Zaptec api itself must be separated out to a separate package on pypi
  • The coding standard must be updated to fulfil the Home Assistant quality scale
  • A series of PRs adding the Zaptec integration into ha-core. Here there is a convention to adding only one feature or file at a time, in order to make the changes small enough to be reviewable. So there will be many PRs and it will be waiting on collaborators able to approve.

More info here: https://developers.home-assistant.io/docs/creating_component_code_review

@Hellowlol
Copy link
Collaborator

It really not worth it imo

@c0mplex1
Copy link
Contributor

c0mplex1 commented Nov 1, 2024

@sveinse
Considering the huge amount of work that needs to be put into making the zaptec integration part of HA, I now also wonder if it is worth it.
Will the adjustment and/or expansion of the integration remain as flexible as it is now, or will it become a sluggish process if it has to be approved by many collaborators first.
Decisions, decisions, decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants