Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guest user - mandatory fields: events are submitted for review without "type d'événement" mandatory field filled. #98

Open
MaudeFJ opened this issue Nov 4, 2024 · 14 comments
Assignees
Labels
Milestone

Comments

@MaudeFJ
Copy link

MaudeFJ commented Nov 4, 2024

NEW information:

@AbhishekPAnil please see this event
This event is set to Pending Review; however, the "Types d'événements" is missing content. "Types d'événements" is a mandatory field so the guest user should not be able to send it for review.
Expected behaviour for guest users to submit events for review:

all mandatory fields must be filled to send for review.

Previous information

Description:
Event type is required; however this guest user can send things for review without adding event type - https://cms.footlight.io/dashboard/63457978637093005071a053/settings/user-management/648b2e125526a700645036b9

Event type is a mandatory field.
Expected behaviour: all mandatory fields must be filled before guest users can send for review.

Maude added the event type to this event after noticing this issue: And this one for sure https://cms.footlight.io/dashboard/63457978637093005071a053/events/671c4933017105006372cf8e

Please look into the logs to see what happened.

Note: Maude also mentioned that some of these events had the same bug (event was sent to review without all. mandatory fields filled). She already fixed the problematic issues yesterday
https://cms.footlight.io/dashboard/63457978637093005071a053/events?page=1&order=asc&sortBy=upcomingEventDate&organizers=64428128f45aca00641277f8

Type d'événement est obligatoire, mais j'ai plusieurs événments qui étaient en attente de révision qui n'avait rien dans ce champs...
Merci

@troughc
Copy link

troughc commented Nov 4, 2024

@MaudeFJ I just tried it out in both you cms and our staging environment and i was not able to send an event for review with that field empty. In other words I could NOT submit an event for review with the event type empty.
Screenshot
Screenshot 2024-11-04 at 3 52 52 PM

Can you please give me an example of an event that was sent for review without that field filled? Do you have any examples? I could not find one in your database.
Merci

@MaudeFJ
Copy link
Author

MaudeFJ commented Nov 5, 2024 via email

@MaudeFJ
Copy link
Author

MaudeFJ commented Nov 5, 2024

@troughc troughc assigned AbhishekPAnil and unassigned MaudeFJ Nov 5, 2024
@troughc troughc added the bug label Nov 5, 2024
@troughc troughc assigned sahalali and unassigned sahalali Nov 5, 2024
@AbhishekPAnil
Copy link

@troughc Please check if the concepts concepts are showing properly in above mentioned events.

@troughc
Copy link

troughc commented Nov 7, 2024

This seems to be fixed: PASSED
@MaudeFJ please let us know if you see this happening again. We were not able to diagnose what was causing the issue but we found the events that are missing the event type and fixed them.

@troughc
Copy link

troughc commented Nov 7, 2024

@MaudeFJ These are events that we fixed:

@troughc
Copy link

troughc commented Nov 7, 2024

@sahalali @AbhishekPAnil regarding the following IDs, they are generating errors. Can you tell me why? I am not sure which events they are (by event title).
64959d7295ffd60064aa8f3e
649479b595ffd60064aa4237
649090465526a7006450adf1
Here are links to where I see the errors (in events).
https://cms.footlight.io/dashboard/63457978637093005071a053/events/64959d7295ffd60064aa8f3e
https://cms.footlight.io/dashboard/63457978637093005071a053/events/649479b595ffd60064aa4237
https://cms.footlight.io/dashboard/63457978637093005071a053/events/649090465526a7006450adf1

@AbhishekPAnil
Copy link

@sahalali @AbhishekPAnil regarding the following IDs, they are generating errors. Can you tell me why? I am not sure which events they are (by event title). 64959d7295ffd60064aa8f3e 649479b595ffd60064aa4237 649090465526a7006450adf1 Here are links to where I see the errors (in events). https://cms.footlight.io/dashboard/63457978637093005071a053/events/64959d7295ffd60064aa8f3e https://cms.footlight.io/dashboard/63457978637093005071a053/events/649479b595ffd60064aa4237 https://cms.footlight.io/dashboard/63457978637093005071a053/events/649090465526a7006450adf1

@troughc I don't think these are the correct url's.These event ids belong to Tout Culture and not Signe Laval.Could you check if these are working for you!

https://cms.footlight.io/dashboard/6308ef4a7f771f00431d939a/events/64959d7295ffd60064aa8f3e
https://cms.footlight.io/dashboard/6308ef4a7f771f00431d939a/events/649479b595ffd60064aa4237
https://cms.footlight.io/dashboard/6308ef4a7f771f00431d939a/events/649090465526a7006450adf1

@troughc
Copy link

troughc commented Nov 8, 2024

This is good to go - PASSED. I am closing this issue with the caveat that we do not know what caused this.
Thanks @AbhishekPAnil

@troughc troughc closed this as completed Nov 8, 2024
@MaudeFJ
Copy link
Author

MaudeFJ commented Dec 4, 2024

Hello,
I think i got the same problem again..
I added it in carmen while it was in attente d'abrobation and put it back in brouillon. And when i was send for approbation again it was missing.
(i added it again cause i forgot our match plan but next one i'm doing a doublon so we can see the probleme and i can still put it online)

@MaudeFJ
Copy link
Author

MaudeFJ commented Dec 11, 2024

Hi it happend again
Here is an event i did not modifed so you can check out the problem :
https://cms.footlight.io/dashboard/63457978637093005071a053/events/6753429b371a4e0063d6686e

@troughc troughc reopened this Dec 11, 2024
@troughc troughc assigned AbhishekPAnil and unassigned troughc and sahalali Dec 11, 2024
@troughc
Copy link

troughc commented Dec 11, 2024

@AbhishekPAnil please see this event
This event is set to Pending Review; however, the "Types d'événements" is missing content. "Types d'événements" is a mandatory field so the guest user should not be able to send it for review.
Expected behaviour for guest users to submit events for review:

  • all mandatory fields must be filled to send for review.

@troughc troughc changed the title bug : multiple event without "type d'événement" were being send for révision Guest user - mandatory fields: events are submitted for review without "type d'événement" mandatory field filled. Dec 11, 2024
@troughc troughc added this to the CC 2024.3 milestone Dec 19, 2024
@sahalali sahalali modified the milestones: CC 2024.3, CC 2025.1 Jan 9, 2025
@AbhishekPAnil
Copy link

@dev-aravind This seems to be a backend issue.Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants