Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New doublon in arts data- but old one not.. #85

Open
MaudeFJ opened this issue Sep 4, 2024 · 4 comments
Open

New doublon in arts data- but old one not.. #85

MaudeFJ opened this issue Sep 4, 2024 · 4 comments
Assignees

Comments

@MaudeFJ
Copy link

MaudeFJ commented Sep 4, 2024

Capture d’écran, le 2024-09-04 à 14 18 26
I'm wondering why.. ?

Also, some feature that would be nice to have in the future is like an avertissement when creating a doublon like " Hey the thing your creating is oddly similar to this"

@troughc troughc assigned saumier and unassigned saumier Sep 4, 2024
@troughc
Copy link

troughc commented Sep 4, 2024

@MaudeFJ Initially I wasn't sure why the person 'catelier' decided to add the Place from Artsdata rather than use the one that is already in Footlight. But after some tests (see below) I think it's because they didn't include the hyphens (-). We are working on improving the search algorithm in Footlight so that this doesn't happen.

Here are my findings.
I tested this by trying to create the place myself. As soon as I started typing in the Places workspace, I got this:
Screenshot 2024-09-04 at 4 13 54 PM
And scrolling down I see this:
Screenshot 2024-09-04 at 4 14 11 PM

When i typed the whole name (with hyphens) in the event form Location field (in the Events workspace), I saw this:

Screenshot 2024-09-04 at 4 19 52 PM

HOWEVER, when I typed the the whole name without hyphens, this happened.

Screenshot 2024-09-04 at 4 22 43 PM

As a side note, the reason there are two instances for this place (one in Footlight, one in Artsdata) because the one you and I created in Footlight is not linked to the one in Artsdata. Once they are linked, I believe you would only see one.
@saumier please correct me if I misunderstand how that works.

@troughc
Copy link

troughc commented Sep 4, 2024

Regarding Also, some feature that would be nice to have in the future is like an avertissement when creating a doublon like " Hey the thing your creating is oddly similar to this"
This request should be met by improving the search algorithm to catch these special cases.

@MaudeFJ
Copy link
Author

MaudeFJ commented Sep 4, 2024

Humm i see. Thanks !

@saumier
Copy link
Member

saumier commented Sep 6, 2024

@MaudeFJ @troughc I opened an issue to relink the good place in CMS to Artsdata.
culturecreates/footlight-aggregator#129

I also noticed that the place in Artsdata has a different postal code than the place in CMS. H7L 1M9 (laval.ca data) versus H7L 1M7 (CMS). In Google it looks like H7L 1M9 is closer to the entrance of the parc so I will keep that one.

@saumier saumier removed their assignment Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants