Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-only view - language literal tag and fallback language #1507

Open
2 tasks
troughc opened this issue Dec 11, 2024 · 2 comments
Open
2 tasks

Read-only view - language literal tag and fallback language #1507

troughc opened this issue Dec 11, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@troughc
Copy link
Contributor

troughc commented Dec 11, 2024

These issues were found in #1394. I would like some (3) updates to be made:

  • 1. Add the fallback language literal tag to the read only view.

  • 2. the fallback language in the read-only page should be the same as the fallback language in the Edit page.
    When I change the order of languages in settings, i am changing the fallback language choice. When I then create an event (or other entity), the read-only page does not update to reflect my new fallback language choice.
    For example, change the order in Settings from having FRENCH first to ENGLISH first (this changes the fallback language from French to English).
    The expected behaviour is that the fallback language would be English everywhere (i.e. English in Read only and in Edit view).

wrong fallback language in read only

Image

right fallback language in edit view

Image

@troughc troughc added the estimate needed Add estimate for planning label Dec 11, 2024
@troughc troughc added the bug Something isn't working label Dec 12, 2024
@SyamBabu-M
Copy link
Contributor

@troughc
Estimate:

  1. Add the fallback language literal tag to the read only view pages. - 10h + 1h

  2. the fallback language in the read-only page should be the same as the fallback language in the Edit page. - 4h + 1h

  3. the ticketing fields in the Edit view are not displaying fallback languages and the literal tag when they are empty. - 8h
    @troughc I investigated this and it seems a bit difficult to find a good solution. I suggest separating this from this issue.

@SyamBabu-M SyamBabu-M added to be scheduled Work has been estimated, now it needs a priority and milstone and removed estimate needed Add estimate for planning labels Dec 17, 2024
@SyamBabu-M SyamBabu-M assigned troughc and unassigned SyamBabu-M Dec 17, 2024
@troughc
Copy link
Contributor Author

troughc commented Dec 19, 2024

@SyamBabu-M I like your suggestion to separate the issue about ticketing. DONE - see #1521
I also removed that section from this ticket.

@troughc troughc modified the milestone: CC 2024.3 Dec 19, 2024
@sahalali sahalali modified the milestones: CC 2024.3, CC 2025.1 Jan 9, 2025
@troughc troughc assigned SyamBabu-M and unassigned troughc Jan 9, 2025
@troughc troughc removed the to be scheduled Work has been estimated, now it needs a priority and milstone label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants