Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Users to filter options in all list views #1471

Closed
1 task
troughc opened this issue Nov 27, 2024 · 10 comments · Fixed by #1502
Closed
1 task

add Users to filter options in all list views #1471

troughc opened this issue Nov 27, 2024 · 10 comments · Fixed by #1502
Assignees
Labels
enhancement New feature or request To be deployed
Milestone

Comments

@troughc
Copy link
Contributor

troughc commented Nov 27, 2024

Add the Users filter to other workspace List views (in People, Places, Organizations list views)
Same filter as is used in Events

Tasks

Preview Give feedback
  1. kmdvs
@troughc troughc added enhancement New feature or request estimate needed Add estimate for planning labels Nov 27, 2024
@AbhishekPAnil
Copy link
Contributor

Estimate : 8H

  1. Copy the logic and integration for Users filter from Events listing page into :
  • Place -2
  • People -2
  • Organization -2
  1. Testing - 2

@AbhishekPAnil
Copy link
Contributor

@SuhailAliyar
Kindly include support in the Places, People, and Organization listing APIs to retrieve details based on the created user.

@sahalali
Copy link
Contributor

sahalali commented Dec 2, 2024

Backend estimate: 2 Hrs

@sahalali sahalali removed the estimate needed Add estimate for planning label Dec 2, 2024
@troughc troughc added the to be scheduled Work has been estimated, now it needs a priority and milstone label Dec 2, 2024
@troughc troughc added this to the CC 2024.2 milestone Dec 3, 2024
@sahalali sahalali removed the to be scheduled Work has been estimated, now it needs a priority and milstone label Dec 6, 2024
@SyamBabu-M SyamBabu-M linked a pull request Dec 10, 2024 that will close this issue
@SyamBabu-M SyamBabu-M assigned troughc and unassigned dev-aravind and SyamBabu-M Dec 10, 2024
@SyamBabu-M
Copy link
Contributor

@dev-aravind frontend development is complete. Please move this to review after updating staging

@SyamBabu-M SyamBabu-M assigned dev-aravind and unassigned troughc Dec 10, 2024
@dev-aravind
Copy link
Contributor

@SyamBabu-M There is a small change, the created by param is now changed to created-by instead of user in all pages. Please update the FE to support this.

@SyamBabu-M
Copy link
Contributor

There is a change in frontend after the param name was changed

estimate for this change and testing - 1h

@troughc
Copy link
Contributor Author

troughc commented Dec 11, 2024

Tested in chrome.
@SyamBabu-M it is working well. One request: can you add any new filter (in this case Users) on a new line the way we do in Events etc. Meaning, the search bar and sorting is on one line and filters are on next line(s). (I have screenshots to show you what I mean)
This should be how it is displayed for filters, including standard andthose set by the admin - this is not the case right now. (see my screenshot of the Organizations list view)

example 1 - events list view

Screenshot 2024-12-11 at 1 05 52 PM

Example 2 - Taxonomies list view with filter on second line

Screenshot 2024-12-11 at 1 05 59 PM

Example 3 is not laid out correctly: Organizations with custom filter and new User filter on first line instead of a new line

Screenshot 2024-12-11 at 1 08 01 PM

@troughc
Copy link
Contributor Author

troughc commented Dec 18, 2024

Tested: PASSED

@troughc troughc assigned sahalali and unassigned troughc Dec 18, 2024
@SyamBabu-M
Copy link
Contributor

@troughc Should we wait for the regression test update before going live?

@sahalali
Copy link
Contributor

I don't see any reason for this enhancement to be delayed until the regression tests are complete, as this change will not break any existing regression tests. However, a separate ticket should be created and assigned to Kim for updating the regression tests related to this enhancement.

cc @troughc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request To be deployed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants