Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin only fields as filters in list view not working #1470

Closed
troughc opened this issue Nov 27, 2024 · 10 comments · Fixed by #1519
Closed

admin only fields as filters in list view not working #1470

troughc opened this issue Nov 27, 2024 · 10 comments · Fixed by #1519
Assignees
Labels
bug Something isn't working To be deployed
Milestone

Comments

@troughc
Copy link
Contributor

troughc commented Nov 27, 2024

Admin only taxonomies can be set as filters. these filters appear in the List view and should only be visible to an Admin.
I tested this on Tout Culture with the member of taxonomies - there is one for organizations and one for people.
I was able to set it as a filter: however, it doesn't work (doesn't filter correctly); and, the filter is visible to me when I sign on as a guest.
Expected behaviour: Admin only filters work to filter according to the taxonomy and are only visible to Admins.

Steps:

  1. turn on 'make this taxonomy available as a filter" in Taxonomies for one that is restricted to Admin only. (this is already done for the member of an organization)
  2. Go to General settings and select the taxonomy under Filter personalization (this one is in ORganizations) and then save.
  3. go to Organizaitons - the filter is there. Try it, it doesn't filter correctly
  4. log in as a guest - the filter is still displayed in organizations.
  5. Do the same with the individual member taxonomy - this one does seem to filter but it is available for guests as well.
@troughc troughc added the bug Something isn't working label Nov 27, 2024
@troughc troughc assigned sahalali and unassigned AbhishekPAnil Nov 27, 2024
@troughc troughc added the estimate needed Add estimate for planning label Nov 28, 2024
@troughc
Copy link
Contributor Author

troughc commented Nov 28, 2024

@sahalali I'm not sure if this is for you or @AbhishekPAnil to estimate?

@AbhishekPAnil
Copy link
Contributor

AbhishekPAnil commented Nov 29, 2024

cc @troughc Work needs to be done in both frontend and backend.

When used as a filter :
Taxonomy fields designated as admin-only should be visible to admins.
The work for the above needs to be done in the frontend only.Below are the estimates for the same.

Estimate : 10H

  1. Add a common logic to detect the admin only taxonomies and display them accordingly to the specific user type. -3- 4
  2. Update the logic in Events,Organization,People and Place workspaces.1+1+1+1.
  3. Testing - 2

@AbhishekPAnil AbhishekPAnil removed their assignment Nov 29, 2024
@sahalali
Copy link
Contributor

sahalali commented Dec 2, 2024

Backend estimation: 8 Hrs

@sahalali sahalali removed the estimate needed Add estimate for planning label Dec 2, 2024
@sahalali sahalali assigned troughc and unassigned sahalali Dec 2, 2024
@troughc troughc added the to be scheduled Work has been estimated, now it needs a priority and milstone label Dec 2, 2024
@sahalali sahalali assigned SyamBabu-M and dev-aravind and unassigned troughc Dec 6, 2024
@sahalali sahalali added this to the CC 2024.2 milestone Dec 6, 2024
@troughc troughc removed the to be scheduled Work has been estimated, now it needs a priority and milstone label Dec 6, 2024
@dev-aravind
Copy link
Contributor

dev-aravind commented Dec 9, 2024

@AbhishekPAnil @SyamBabu-M There are no back-end dependencies here. The param should be passed as concept-ids instead of concept in the organization listing page Check this for reference.

@dev-aravind dev-aravind removed their assignment Dec 9, 2024
@SyamBabu-M SyamBabu-M linked a pull request Dec 19, 2024 that will close this issue
@SyamBabu-M SyamBabu-M assigned troughc and unassigned SyamBabu-M Dec 19, 2024
@troughc
Copy link
Contributor Author

troughc commented Dec 19, 2024

Tested: PASSED
One thing that could be fixed before deploying @SyamBabu-M : please make sure the filters are displayed on a second line (not on the same line as the search field and sort widget).
thanks!
Update: please deploy when you have fixed the layout. Thanks!

@troughc troughc added question Further information is requested and removed Tout Culture To be deployed labels Dec 19, 2024
@sahalali sahalali modified the milestones: CC 2024.2, CC 2024.1, CC 2024.3 Dec 23, 2024
@SyamBabu-M SyamBabu-M assigned troughc and unassigned SyamBabu-M Jan 3, 2025
@troughc
Copy link
Contributor Author

troughc commented Jan 6, 2025

Tested: everything is working.

@SyamBabu-M can you check this?
One thing that may be a related bug: when I log in as a GUEST, I can't see the filters (this is correct); however, I can see that an organizaton is a member of an organization in the read onlyn page.
See this org for example: https://pr-1519.dla06mbe0wyl7.amplifyapp.com/dashboard/6308ef4a7f771f00431d939a/organizations/6451600fe19f7200646d1fca

Expected behavior: guests cannot see Admin ONLY fields (for example, members of organizations data) in read only (or the edit form) pages. That field should not be visible to guests because it is an Admin only field.

@troughc troughc assigned SyamBabu-M and unassigned troughc Jan 6, 2025
@troughc
Copy link
Contributor Author

troughc commented Jan 6, 2025

UPDATE: this bug is also in production, so it probably pre-existed to this issue. See this organization: https://cms.footlight.io/dashboard/6308ef4a7f771f00431d939a/organizations/6451600fe19f7200646d1fca

@AbhishekPAnil AbhishekPAnil removed the question Further information is requested label Jan 8, 2025
@SyamBabu-M SyamBabu-M removed their assignment Jan 8, 2025
@troughc
Copy link
Contributor Author

troughc commented Jan 9, 2025

Tested: PASSED

@troughc
Copy link
Contributor Author

troughc commented Jan 9, 2025

Tested: PASSED
@SyamBabu-M I am having the same bug in Github: I can't use the labels or reassign this issue to someone else.
This is ready to be deployed.

@troughc troughc assigned sahalali and unassigned troughc Jan 9, 2025
@troughc
Copy link
Contributor Author

troughc commented Jan 9, 2025

Never mind @SyamBabu-M it seems to be working now.

@sahalali sahalali modified the milestones: CC 2024.3, CC 2025.1 Jan 9, 2025
AbhishekPAnil added a commit that referenced this issue Jan 10, 2025
fix: made custom filters admin only. closes #1470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working To be deployed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants