Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy concept list enhancement phase 1 #1456

Open
4 tasks
troughc opened this issue Nov 21, 2024 · 3 comments
Open
4 tasks

Taxonomy concept list enhancement phase 1 #1456

troughc opened this issue Nov 21, 2024 · 3 comments
Assignees
Labels
to be scheduled Work has been estimated, now it needs a priority and milstone

Comments

@troughc
Copy link
Contributor

troughc commented Nov 21, 2024

Usability enhancement (user experience) for #1302
See figma https://www.figma.com/design/DBnSSMT9Etfm6guDKKSp8O/Culture-Creates---Footlight-Calendar?node-id=11193-74280&t=zJtuT9Pep9N1Ofuj-1

To do in this issue:

  • add more options to the context menu on the right of a concept (Do not do the "Set as default" option in this issue - we will do this in a separate issue as it is complex)
  • When a concept is in edit mode, the user should not be able to move the row.
  • When a user adds a new concept row, the first field should be set to edit mode and be empty. This will tell the user to add the concept name right away (and help avoid having badly named concepts). All concepts in the row should be empty fields. This way the fallback language will be used if the user doesn't fill the other fields.
  • If a field is empty, the user needs to be able to enter it in edit mode. There is a cursor for this in the screenshot below. Note that there is also a checkmark they can use to save the change.

Please review this screenshot from the figma for guidance.
Screenshot 2024-11-21 at 12 10 48 PM

@troughc troughc added the estimate needed Add estimate for planning label Nov 21, 2024
@troughc troughc changed the title title tbd Taxonomy concept list enhancement phase 1 Nov 21, 2024
@SyamBabu-M SyamBabu-M added to be scheduled Work has been estimated, now it needs a priority and milstone and removed estimate needed Add estimate for planning labels Dec 3, 2024
@troughc
Copy link
Contributor Author

troughc commented Dec 3, 2024

@SyamBabu-M can you please add the estimate in hours?

@sahalali sahalali added estimate needed Add estimate for planning and removed to be scheduled Work has been estimated, now it needs a priority and milstone labels Dec 3, 2024
@SyamBabu-M
Copy link
Contributor

SyamBabu-M commented Dec 3, 2024

Estimate:

1: Logic to handle new options in dropdown(edit,delete,add above/below, add as sub concept above/below) - 25h
2: Disabling drag when the row is in edit mode - 4h
3: Change to a new concept adding logic - 16h
4: Bug- unable to edit empty concepts - 4h
5: Adding a checkmark icon - 8h.

Questions:-
1: I am assuming that upon clicking on the checkmark the concept is saved and the text area disappears. Is this correct?
2: What happens to the language literal tag? There is not enough room for literal tag and checkmark, especially when you have 4-5
calendar languages.
3: What happens when a user presses anywhere outside on the screen(the current mechanism), instead of on the checkmark. Will it
save the concept?

@SyamBabu-M SyamBabu-M added the question Further information is requested label Dec 3, 2024
@troughc
Copy link
Contributor Author

troughc commented Dec 3, 2024

@SyamBabu-M please see my answers below:

1: I am assuming that upon clicking on the checkmark the concept is saved and the text area disappears. Is this correct? YES Also, happens when you press the Enter button.
2: What happens to the language literal tag? There is not enough room for literal tag and checkmark, especially when you have 4-5 calendar languages. when you click to edit a field with a language literal tag displayed, the language literal disappears. If you don’t change the text at all, the language literal would be there the next time (this is how it is supposed to work in every other field, everywhere else); if you do make an edit, the language literal is gone (because you have created a new language literal for the right language in that field.
3: What happens when a user presses anywhere outside on the screen(the current mechanism), instead of on the checkmark. Will it save the concept? NO If you click away from the field, nothing is changed. Rather, it acts like the esc button, changes are not saved. Changes are saved only when you click the checkmark or press enter.

Let me know if this makes sense to you.

@troughc troughc removed the question Further information is requested label Dec 3, 2024
@troughc troughc removed their assignment Dec 3, 2024
@SyamBabu-M SyamBabu-M added to be scheduled Work has been estimated, now it needs a priority and milstone and removed estimate needed Add estimate for planning labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be scheduled Work has been estimated, now it needs a priority and milstone
Projects
None yet
Development

No branches or pull requests

3 participants