Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mandatory fields to Quick create modals #1445

Open
AbhishekPAnil opened this issue Nov 13, 2024 · 4 comments
Open

Add mandatory fields to Quick create modals #1445

AbhishekPAnil opened this issue Nov 13, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@AbhishekPAnil
Copy link
Contributor

AbhishekPAnil commented Nov 13, 2024

Currently, the quick create modals (Place/Person/Organization) include a fixed set of predefined fields, while additional fields are available in the full edit forms for each entity. When a user sets a field as mandatory, it is automatically reflected in the edit form, but not in the quick create modals. Mandatory fields should automatically appear in the quick create modals as well.

Expected behaviour: All mandatory fields will appear in associated Quick Create modal and are marked as required (red asterisk). If the user doesn't fill the mandatory field, they cannot save (get the error and notification to add the missing data). When all mandatory fields are filled, they can.

@AbhishekPAnil AbhishekPAnil added the enhancement New feature or request label Nov 13, 2024
@troughc troughc added the estimate needed Add estimate for planning label Nov 13, 2024
@sahalali
Copy link
Contributor

@troughc Are we restring users from creating/updating place/person/organization without any mandatory fields?

@troughc
Copy link
Contributor

troughc commented Nov 14, 2024

Yes.

@troughc troughc removed their assignment Nov 14, 2024
@sahalali sahalali added backlog and removed backlog_ labels Nov 18, 2024
@troughc troughc added this to the CC 2024.1 milestone Nov 18, 2024
@troughc troughc removed the backlog label Nov 18, 2024
@AbhishekPAnil
Copy link
Contributor Author

Frotend tasks :24
Add each fields to the quick create modals if its mandatory:8+8+8

@sahalali
Copy link
Contributor

Backend estimate: 12 Hrs
Add validations to all place, person and organization Add-Update APIs.

@sahalali sahalali removed the estimate needed Add estimate for planning label Nov 21, 2024
@troughc troughc added the to be scheduled Work has been estimated, now it needs a priority and milstone label Nov 22, 2024
@troughc troughc assigned troughc and unassigned sahalali Nov 22, 2024
@troughc troughc removed this from the CC 2024.1 milestone Nov 22, 2024
@troughc troughc added this to the CC 2024.3 milestone Dec 19, 2024
@troughc troughc assigned AbhishekPAnil and sahalali and unassigned troughc Dec 19, 2024
@troughc troughc removed the to be scheduled Work has been estimated, now it needs a priority and milstone label Dec 20, 2024
@sahalali sahalali removed their assignment Jan 8, 2025
@sahalali sahalali modified the milestones: CC 2024.3, CC 2025.1 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants