-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Duplicates - Phase 1 - events #1200
Comments
@troughc
|
Frontend estimates : 166H Events: 46H
People : 40H
Place : 40H
Organization : 40H
|
@saumier can you please review my answers below when you get back? Let us know if you agree or have other insights.
QUESTION: If the Artsdata ID pre-exists is it even possible to add a duplicate to the CMS? If yes, you can base the comparison of finding duplicates on an event or event series have the same artsdata ID. Bigger picture (when we do automatic detection of duplicates): I suggest that the duplicate search comparison for EVENTS should be based on title, date(s) and location. For Places, based on name and address/postal code for organizations and people, based on name.
|
@AbhishekPAnil I would like to get feedback from @saumier when he returns, but I am assigning this back to you so you are not blocked from doing your estimate. thanks! |
@troughc @sahalali In all cases of entities resulting from a merge, I think the Artsdata IDs in CMS that are different should be added to the merged entity without any special consideration. It will help traceability. This is also true for sameAs URIs that are not visible to the user in the UI and cannot be selected by the user (like Footlight Console URIs, Caligram URIs, ...). Even if an event has 2 or 3 or 4 ... Artsdata IDs after the merge. For there to be more than 1 Artsdata ID there has been an error somewhere in Artsdata. I don't think CMS should be responsible for choosing the right Artsdata ID and there is no visibility in CMS of the ID of Artsdata IDs which makes it currently impossible for a user to select one. Let Artsdata be responsible to link or mint on its own and create the sameAs between Artsdata IDs if needed. In the CMS UI that has a link to Artsdata, it can link to the first arbitray Artsdata ID if there is more than one Artsdata ID in the merged event. |
cc @AbhishekPAnil For this pass add select all checkbox to the top of the listing pages. |
@troughc Should a user be able to share the list of selected duplicates ?Like the event listing with the selected filters we have right now! |
This has been noted . |
Task for @dev-aravind: Modify all the entities update APIs to remap duplicate entity references to the merged one. Organizations - Referenced in Events |
@AbhishekPAnil The backend changes can be found in this branch. Please test it and let me know if you need any changes. |
@AbhishekPAnil I replied to your question in the Figma. |
cc @AbhishekPAnil Will be displaying the dates separately even if the events have same dates. |
@AbhishekPAnil What is the status of this ticket? |
This is in progress. Currently working on integrating the language changes that syam did.I am doing this ticket in parallel. |
@saumier I have question, what if the event date / title is mismatching with the Artsdata entity. |
cc @dev-aravind
|
@sahalali My opinion has not changed. I still think the merge should not worry about anything else but merging. Since the CMS has no UI to edit or change sameAs URIs there should not be any business logic in how to treat them other than merge. When the data is loaded into Artsdata it will be handled there. In most cases the script that links and unlinks CMS to Artsdata will take care of it. That script is where the business logic should be focused on and only there. The other advantage of merging all sameAs identifiers that that it will appear in the logs and change history even if it gets unlinked in the next step. |
Cc @AbhishekPAnil Add the remaining estimates for the event -merge duplicates and create separate tickets for the other workspaces and re-estimate the same. |
Remaining estimates : |
First: sorry if this ticket already exists - I could not find it in our board.
Final LINK
https://www.figma.com/design/DBnSSMT9Etfm6guDKKSp8O/Culture-Creates---Footlight-Calendar?node-id=10157-100372&m=dev
New feature for Admins only to merge duplicates. This feature will be available in all workspaces lists (events, people, places, organizations). The Figma illustrates the events view as an example/model for how to implement
Of note: the checkboxes (left of the thumbnail image in the list views) will always be displayed for Admins. The checkboxes are not displayed for other user profiles.
French translations have been added in FIGMA
Tasklist :
Events:
People :
Place :
Organization :
Tasks
The text was updated successfully, but these errors were encountered: