Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizers missing name #6

Closed
saumier opened this issue Oct 16, 2024 · 5 comments
Closed

Organizers missing name #6

saumier opened this issue Oct 16, 2024 · 5 comments
Assignees

Comments

@saumier
Copy link
Member

saumier commented Oct 16, 2024

There are many organizations that are related to events through the schema:organizer property. But most Organizations are missing a name (mandatory) and should ideally have a sameAs. This is triggering a SHACL validation error.

@saumier
Copy link
Member Author

saumier commented Oct 16, 2024

@dev-aravind Can you remove the event organizations that have no name from the data sent to Artsdata. I will take care of asking NAC to make the change to their JSON-LD.

@dev-aravind
Copy link
Contributor

@saumier This is fixed in Artsdata right now. Please test it out and let me know if you see any issues.

@dev-aravind dev-aravind assigned saumier and unassigned dev-aravind Oct 21, 2024
@dev-aravind dev-aravind moved this from In Progress to In Review in Artsdata Oct 21, 2024
@saumier
Copy link
Member Author

saumier commented Oct 21, 2024

@dev-aravind The organizers with blank names are removed, however, the organizers that have names are also removed.

This event has an organizer that has a name and should not be removed:
https://kg.artsdata.ca/en/entity?uri=https%3A%2F%2Fnac-cna.ca%2Fen%2Fevent%2F35975%232025-05-04T15%3A00%3A00-04%3A00

If you click the dereference link in Nebula, you can see that the JSON-LD on the webpage has an organizer https://nac-cna.ca/en/theatrefrancais that should remain. So in Artsdata this event should end up with 2 organizers: the one from the webpage and the one we add by default in the pipeline.

@saumier saumier assigned dev-aravind and unassigned saumier Oct 21, 2024
@saumier saumier moved this from In Review to Todo in Artsdata Oct 21, 2024
@dev-aravind
Copy link
Contributor

dev-aravind commented Oct 22, 2024

@saumier This is a raw file from an import before the remove organizations SPARQL was added. I did not find any organization for that particular event in this. Can you please double check this?

Update: The organization issue is fixed now. Please check the same event that you mentioned in the previous comment to verify the event. Thanks.

@dev-aravind dev-aravind assigned saumier and unassigned dev-aravind Oct 22, 2024
@dev-aravind dev-aravind moved this from In Progress to In Review in Artsdata Oct 22, 2024
@saumier
Copy link
Member Author

saumier commented Oct 22, 2024

@dev-aravind You nailed it. Perfect. I'm closing this issue. Thx.

@saumier saumier closed this as completed Oct 22, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Artsdata Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants