Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL when adding / removing operations from URLs/gists #146

Closed
alukach opened this issue Jun 15, 2015 · 2 comments
Closed

Update URL when adding / removing operations from URLs/gists #146

alukach opened this issue Jun 15, 2015 · 2 comments

Comments

@alukach
Copy link
Member

alukach commented Jun 15, 2015

When a layer is added to DropChop via URL or Gist (using the Add menu), the window.location.pathname should be updated to reflect the new layer.

When a layer that was added via URL or Gist is removed from DropChop, the window.location.pathname should be updated to reflect the removed layer. This may rely on the completion of #140.

I see this as having two gains:

  1. Better maintain state between sessions. This is actually somewhat minor if the operations are saved between sessions (cached or saved via other service).
  2. Improve awareness of the ability to append gist, url, or stream to the URL to load data.
@jczaplew
Copy link
Contributor

I think this was closed with #204. Can you please confirm it's the same?

@alukach
Copy link
Member Author

alukach commented Nov 8, 2015

Oops, slow reply, looks to be all taken care of, nice work @jczaplew!

@alukach alukach closed this as completed Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants