Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyphens converted to em-dash #24

Open
tcatapano opened this issue Jun 15, 2018 · 2 comments
Open

hyphens converted to em-dash #24

tcatapano opened this issue Jun 15, 2018 · 2 comments
Assignees
Labels

Comments

@tcatapano
Copy link
Member

per Tillmann:

I just spotted a bug looking at the translation of 166r in the minimal edition: two em-dashes which should be hyphens (“long-buried” and “ready-made”). I thought I’d mention it in case it’s a more widespread issue.

@tcatapano
Copy link
Member Author

E.g., see 166r "long—buried" etc... Seems to be a result of conversion from xml to md as hyphen is used in GDrive (https://docs.google.com/document/d/1mM1YRU3eSGWJXapbYtibWg00NsG1HnY2ZtsFgk0S0bs) and is also present in derived XML (https://github.com/cu-mkp/ms-xml/blob/master/tl/tl_p166r_preTEI.xml). Also renders properly in DCE (http://edition.makingandknowing.org/#/?m=l&sr=0.50&l=f337,tc,i,0&r=f337,tl,t,0).

@tcatapano
Copy link
Member Author

This is likely the culprit: https://github.com/cu-mkp/ms-xml/blob/master/xslt/entry-to-md.xsl#L269

    <xsl:template match="text()">
        <xsl:value-of select="replace(replace(replace(., '-', '—'), '\s+', ' '), '\+', '\\+')"/>
    </xsl:template>

@tcatapano tcatapano reopened this Jun 15, 2018
@tcatapano tcatapano self-assigned this Jun 15, 2018
@tcatapano tcatapano added the bug label Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant