-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AV sync observation #95
Comments
In principle I support including all 3 of these assuming we are confident they would make a difference. |
Point 1: Point 2: Point 3: |
Updates on Point 3: |
I agree that we should factor the imperfections of the measurement device (i.e. the camera) out of the measurement as far as possible. Therefore,
|
As agreed at Meeting 2024-12-10 on @wschidol's comment: |
@wschidol I have made default pass rate 95% and tolerances at the beginning and the end, measured in milliseconds, default 1000ms (which is 1 seconds). I think from the captured data 100ms was too small. |
@yanj-github Glad to see that we can tighten the pass rate for 95% for the bulk of the signal. Just to clarify... do you mean that
And, if it is 2., for how long at either end can A/V sync be off by up to 1 sec? |
I meant the first and last 1000 ms of the signal are exempt from checking. So we ignore 1st and last 1 seconds audio track. Please note that 1000ms off is based on expected duration not presented duration. |
Just to be clear, if the first 40ms and last 80ms of the 'real' audio data are missing, what would be exempt from a/v sync testing? Would it be 960ms of 'real' data exempt at the start and 920ms exempt at the end? Whatever it is, it should be documented somewhere, if only in the config file where 1000ms is defined. |
@jpiesing Sure it will be documented on OF end. The 1000ms is completely independent to the missing data. AV sync only checked where audio media time is bigger than tolerance 1000ms. |
Only 2 AV sync test passed from last all others FAIL.
AV sync tests requires investigation.
Here is the summary of what I have found:
AV sync result from Berlin Plugfest:
I’ve enhanced the current OF algorithm for comparing matching audio and video pairs and updated the result message to display the percentage of pairs that PASS, and the audio-to-video minimum and maximum differences.
Below are the updated results with this improvement, we now have 3 PASSES.
Improved OF algorithm:
Here is the summary including the percentage of matching audio and video pairs that PASS and the audio-to-video min/max differences:
I’m assuming that Fraunhofer used the same camera for all test recordings.
The observed difference between audio and video indicates a synchronization failure in both directions on some of the devices.
Upon further debugging, I discovered that for some of the devices the AV sync issue only occurs very briefly, after which the playback remains in-sync for the rest of the duration.
Currently, the AV sync is checked for each audio segment throughout the entire playback. The test fails if even one segment is out of sync, which makes it extremely challenging for devices to pass.
Therefore, I propose adding a tolerance threshold for pass/fail criteria. For instance, a brief out-of-sync duration (e.g., couple of seconds) may not be perceptible to the human eye and could be considered acceptable.
Q1: Can we add a pass rate to determine PASS/FAIL? If we allow a threshold of 80%(?) or above to pass, this adjustment will make the pass/fail criteria more practical and achievable.
This accounts for minor discrepancies that are not perceptible to users while maintaining an acceptable standard for performance.
If we add an 80% pass rate, the results now look like this:
Additionally, we can discuss the AV sync tolerance, which is currently set at [40ms, -120ms] compared to the ITU standard [45ms, -125ms].
The current setting aligns with a measurement resolution of 20ms.
Audio is being captured with millisecond-level accuracy. However, due to limitations in the capturing process, video frames might not achieve the same level of precision in millisecond accuracy.
With a 120fps camera, there will be an offset of approximately 8.33ms at either end of the capture. We need to consider this limitation.
Q2: Can we increase the tolerance e.g.: [60ms, -140ms] ?
Note, the measured offsets assume that the camera can record audio and video perfectly in-sync, with no camera offset factored into these measurements.
Q3: Should we allow users to configure a camera recording offset (up to a threshold) when running the OF process?
We must carefully consider the risks, such as:
• Potential misuse: Users might misuse this feature to get a pass.
• Measurement offset inaccuracies: It is hard to measure recording offset accurately; Incorrect offset values could lead to false positives or negatives.
The text was updated successfully, but these errors were encountered: