Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filling variables whose input comes from simtel and corsika #14

Closed
nietootein opened this issue Feb 1, 2018 · 2 comments
Closed

Filling variables whose input comes from simtel and corsika #14

nietootein opened this issue Feb 1, 2018 · 2 comments

Comments

@nietootein
Copy link
Member

Some of the metadata fields that are stored as attributes are currently not being filled, specifically:

  • CORSIKA_ver
  • E_max
  • E_min
  • prod_site_B_field
  • prod_site_alt
  • prod_site_array
  • prod_site_coord
  • prod_site_subarray
  • simtel_ver
  • spectral_index

These data can be found in the simtel history block, but retrieval of such a block through pyhessio/ctapipe has not been implemented (see this issue cta-observatory/pyhessio#52).

@morcuended
Copy link
Member

morcuended commented Feb 8, 2018

I have been looking over pyhessio and ctapipe.io modules and I have managed to retrieve some of the required metadata already considered in pyhessio, at least those I could find easily. This is how it looks so far.

@bryankim96
Copy link
Member

I tried to incorporate these new fields in c7bfcaf and bae7830, but it seems like this update to ctapipe may still be incomplete (see cta-observatory/ctapipe#655). For now they are included in the global metadata dict but I have it try/catch so it does not crash if they are not actually supported in the HDF5 event_source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants