Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact button doesn't change colors when scrolling to it. #112

Open
abelsonlive opened this issue Jun 30, 2013 · 5 comments
Open

Contact button doesn't change colors when scrolling to it. #112

abelsonlive opened this issue Jun 30, 2013 · 5 comments
Assignees
Labels
Milestone

Comments

@abelsonlive
Copy link
Contributor

screen shot 2013-06-30 at 2 53 28 pm

@ghost ghost assigned mhkeller Jun 30, 2013
@tlevine
Copy link
Contributor

tlevine commented Jul 1, 2013

This happens because the "Contact" section heading isn't quite at the top of the page. We could set an offset for the scrollspy, but it looks like the offset option doesn't work in Bootstrap scrollspy. We could fix scrollspy, write something custom to deal with this spying, do some hack like giving the footer a big margin or just ignore it for now. (Or maybe there are other options.)

@mhkeller
Copy link
Member

mhkeller commented Jul 1, 2013

We could make examples the last section, which would be long enough to trigger the spy. I think setting an offset for contacts would mess up the other sections.

Le Jul 1, 2013 à 1:24, Thomas Levine [email protected] a écrit :

This happens because the "Contact" section heading isn't quite at the top of the page. We could set an offset for the scrollspy, but it looks like the offset option doesn't work in Bootstrap scrollspy. We could fix scrollspy, write something custom to deal with this spying, do some hack like giving the footer a big margin or just ignore it for now. (Or maybe there are other options.)


Reply to this email directly or view it on GitHub.

@mhkeller
Copy link
Member

mhkeller commented Jul 3, 2013

Fixed by making custom offset for the contact section csvsoundsystem/treasury.io@ 30df93f548f8f382746a9d2e8dc0e1684c2f4d55

@mhkeller mhkeller closed this as completed Jul 3, 2013
@mhkeller
Copy link
Member

mhkeller commented Jul 7, 2013

Disabled that hack for now since it only works at certain browser widths. Looking into a solution that works no matter the browser width.

@mhkeller mhkeller reopened this Jul 7, 2013
@tlevine
Copy link
Contributor

tlevine commented Jul 31, 2013

This doesn't seem too important, especially considering that we haven't worked on it in a month. I'm moving it to dreams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants