Conflict with pdfcomment

[callegar]

Looks like loading typog breaks the \pdfmarkupcomment command of package pdfcomment (at least when using lualatex). Is this expected. Is there any workaround?

[callegar]

In fact, it is not just \pdfmarkupcomment. Also \pdfcomment and more get broken, leaving empty spaces in the text.

[cspiel]

The problem is not limited to lualatex, it arises with pdflatex, too.
There are no errors or warnings but the output gets mangled really badly.

I could trace the issue to the macro \pdfstringdefDisableCommands.
However, I have not the slighest idea why it wreaks havoc. My "fix" is
not to use the macro if package pdfcomment was loaded.

Please pull the latest revision from the repository
and let my know how things work out on your system.

[callegar]

I have found documentation about the \pdfstringdefDisableCommands in https://texdoc.org/serve/paper.pdf/0. To the best of my understanding, this should be meant for setting up command substitutions for the \texorpdfstring macro, employed e.g. by hyperref to get rid of tex commands when producing PDF strings (e.g. for bookmarks). Apparently it is used quite often in typog. However, I thought this was mainly meant to disable commands, while in typog I see it often used to change a command into some other command. Out of curiosity, why is this needed so frequently? More interestingly, I wonder if calling \pdfstringdefDisableCommands is a problem in itself or if it is some specific command substitution to be problematic. I also wonder if avoiding it altogether could create other issues.

For the time being, I have split out in a mini-package the funtionalities of typog that I actually need (those related to sloppy), controlling other things I use (microtype and setspace) directly.

[cspiel]

Thanks for the reference! I wasn't aware of that document.

Package typog uses \pdfstringdefDisableCommands for the
same reasons as you exemplify in conjunction with package hyperref.
Many of typog's macros commonly occur in calls to sectioning macros (e.g. \section)
from where they get promoted to the PDF documents' bookmarks.
Without the substitutions installed by \pdfstringdefDisableCommands
the bookmarks look downright broken.

With respect to the usage of \pdfstringdefDisableCommands, Sec. 6.2
(bottom of page 14) of the document you quoted seems to confirm my
understanding that it replaces expansions for (textual parts of?) the
PDF-document.

Before you start forking parts of typog... Have you tried 04089e1?
It solves the issue on my system.

[callegar]

Don't worry, not a public fork: it was just a private hack. I'll definitely try your patch.

[cspiel]

You can of course fork all or parts of typog.
That's why its license is permissive and its repo is on github.
I have no problems with that.

I just want you as an alpha-tester for my improvised fix,
so that other users who combine pdfcomment and
typog will benefit from it, too.