Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify course properties to make logic clearer #412

Open
smartspot2 opened this issue May 8, 2023 · 0 comments
Open

Modify course properties to make logic clearer #412

smartspot2 opened this issue May 8, 2023 · 0 comments
Labels
enhancement New feature or request sev4 Normal severity - System impaired

Comments

@smartspot2
Copy link
Member

Currently, there are section_start, valid_until, enrollment_start, and enrollment_end fields on the Course object.

The enrollment_start and enrollment_end fields behave like they should, along with section_start. However, the valid_until field seems to be used for a bunch of different purposes, without much clarity on how it's actually being used. There should probably be a section_end field, denoting when attendances should stop being created (since section_start denotes when attendances start being created). If we want to control visibility, then that should probably be the desired purpose of valid_until.

This could be merged/incorporated into the archiving project (#244, #270), since the valid_until field could probably be used to denote when a semester "ends" for a course.

There could also be several other ways to improve the semantics of the Course object fields not mentioned here, and I'd be open for discussion on it as well.

@smartspot2 smartspot2 added enhancement New feature or request sev4 Normal severity - System impaired labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sev4 Normal severity - System impaired
Projects
None yet
Development

No branches or pull requests

1 participant