-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify app-interact chapter #137
Conversation
8389211
to
a2a4b9a
Compare
Hi, @cosmin1805, thanks for this. Please notify me once your PR covers everything from #76 (and its comments) so that I can mark it as superseded by this. |
Published at https://cs-pub-ro.github.io/operating-systems/137/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for your changes to be rendered to the website [1], you'll need to specify the structure of this chapter in config.yaml
[2], in a way similar to the others ([3] specifies the files used for each lab and [4] specifies the structure of a chapter in the sidebar). To test the website locally, run make build
in the repo's root folder. Fix the errors, then run make serve
.
After this, place the slides in their subchapters' slides/
folders and slides.mdpp
in chapters/app-interact/
.
[1] https://cs-pub-ro.github.io/operating-systems/137/
[2] https://github.com/cs-pub-ro/operating-systems/blob/main/config.yaml
[3]
Lines 94 to 115 in 5315234
- title: Lab 7 - Copy-on-Write | |
filename: lab7.md | |
content: | |
- tasks/apache2.md | |
- tasks/page-faults.md | |
- tasks/shared-memory.md | |
- tasks/mini-shell.md | |
- reading/processes-threads-apache2.md | |
- reading/copy-on-write.md | |
- guides/apache2.md | |
- guides/fork-faults.md | |
- title: Lab 8 - Syncronization | |
filename: lab8.md | |
content: | |
- tasks/race-condition.md | |
- tasks/threadsafe-data-struct.md | |
- tasks/libult.md | |
- reading/synchronization.md | |
- reading/user-level-threads.md | |
- reading/scheduling.md | |
- guides/user-level-threads.md | |
- guides/libult.md |
[4]
Lines 216 to 259 in 5315234
- Compute: | |
path: /build/prepare_view/.view | |
extra: | |
- media | |
subsections: | |
- Slides: /build/embed_reveal/Compute/Compute.mdx | |
- Overview: /build/prepare_view/.view/compute-overview.md | |
- Questions: | |
path: questions | |
subsections: | |
- Parent Faults Before Fork: parent-faults-before-fork.md | |
- Mmap Cow Flag: mmap-cow-flag.md | |
- Sections Always Shared: sections-always-shared.md | |
- Child Faults After Write: child-faults-after-write.md | |
- Seg Fault Exit Code: seg-fault-exit-code.md | |
- Threads Shared Data: threads-shared-data.md | |
- Thread Memory: thread-memory.md | |
- Apache2 Strace: apache2-strace.md | |
- Mini Shell Stops After Command: mini-shell-stops-after-command.md | |
- Cause of File Not Found Error: cause-of-file-not-found-error.md | |
- Process Creation: process-creation.md | |
- Who Calls Execve Parent: who-calls-execve-parent.md | |
- Exec Without Fork: exec-without-fork.md | |
- Create Sleepy Process Ending: create-sleepy-process-ending.md | |
- Processes Speedup: processes-speedup.md | |
- Parent of Sleep Processes: parent-of-sleep-processes.md | |
- Sleeping on a Fiber: sleeping-on-a-fiber.md | |
- Fiber Strace: fiber-strace.md | |
- Type of Scheduler in Libult: type-of-scheduler-in-libult.md | |
- Number of Running Ults: number-of-running-ults.md | |
- Why Use Completed Queue: why-use-completed-queue.md | |
- Ult Thread IDs: ult-thread-ids.md | |
- TCB Libult Unikraft: tcb-libult-unikraft.md | |
- Time Slice Value: time-slice-value.md | |
- Number of Running Threads: number-of-running-threads.md | |
- Notify Only With Mutex: notify-only-with-mutex.md | |
- TLS Var Copies: tls-var-copies.md | |
- TLS Synchronization: tls-synchronization.md | |
- Semaphore Equivalent: semaphore-equivalent.md | |
- Coarse vs Granular Critical Section: coarse-vs-granular-critical-section.md | |
- Not Race Condition: not-race-condition.md | |
- Lab 6 - Multiprocess and Multithread: lab6.md | |
- Lab 7 - Copy-on-Write: lab7.md | |
- Lab 8 - Syncronization: lab8.md |
What are the titles of Lab 12 and Lab 13? How do I decide the order in which to arrange the tasks, and in which lab each task should be included? |
There will only be lab 12 for App Interact. You can see the tasks here [1]. Keep them mostly in the same order, but if you feel that any of them would work better in a different place, feel free to move it. Moving tasks around is as easy as moving one line in [1] Lines 287 to 298 in dc21b9b
|
Published at https://cs-pub-ro.github.io/operating-systems/137/ |
Published at https://cs-pub-ro.github.io/operating-systems/137/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chapter's starting to take a better shape now. I made inline suggestions to make things look better. Most of them should be applied globally. In addition, you should also start looking into the checkpatch [1] and super-linter failures [2]. To fix spellcheck, you'll have to add the false positive words [3] to these wordlist via another PR. Make sure to keep those wordlist sorted.
[1] https://github.com/cs-pub-ro/operating-systems/actions/runs/11975236465/job/33388135941?pr=137
[2] https://github.com/cs-pub-ro/operating-systems/actions/runs/11975236465/job/33388135510?pr=137
[3] https://github.com/cs-pub-ro/operating-systems/actions/runs/11975236465/job/33388135058?pr=137
chapters/app-interact/os-cloud/drills/tasks/os-cloud/solution/initial_setup.sh
Outdated
Show resolved
Hide resolved
Published at https://cs-pub-ro.github.io/operating-systems/137/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some more inline comments about splitting the content. Besides, fix the linter failures [1] (I gave further details here [2]), remove content/chapters/app-interact/
and these comments [3].
[1] https://github.com/cs-pub-ro/operating-systems/pull/137/checks
[2] #137
[3] https://github.com/cs-pub-ro/operating-systems/blob/main/config.yaml#L331-L348
chapters/app-interact/os-cloud/drills/questions/cgroups-vs-namespaces.md
Outdated
Show resolved
Hide resolved
chapters/app-interact/os-cloud/drills/questions/container-vs-vm.md
Outdated
Show resolved
Hide resolved
chapters/app-interact/overview/guides/demo/comm-channels/Makefile
Outdated
Show resolved
Hide resolved
48c362c
to
a04b480
Compare
@teodutu and @Alex-deVis I fixed what I could what is left now is some errors from the io chapter, witch I did rebase but something is still wrong and some that I don't know if I should fix, like:
This one is a the tittle of the file
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, some CI/CD errors won't make sense. Ignore those that don't and fix the others.
You removed a good portion of the spurious files from the I/O chapter. For the rest, you can run git checkout main -- chapters/io/
. and that should synch your local io/
chapter with the one on main
.
e61a715
to
6a08446
Compare
@cosmin1805 I force-pushed your branch to fix the chekpatch. You probably had an outdated local git fetch
git reset --hard <remote-name>/translate_app-interact |
@teodutu Everything looks good now. I also committed the last change I forgot to make earlier. Should I squash all the commits into one? |
Published at https://cs-pub-ro.github.io/operating-systems/137/ |
Almost there, @cosmin1805, just a few more high-level changes. The
Ignore the current issues in |
@Alex-deVis I’ve completed all the requested changes. However, I had a few questions about moving the |
Published at https://cs-pub-ro.github.io/operating-systems/137/ |
6b09fa7
to
1335ee2
Compare
Published at https://cs-pub-ro.github.io/operating-systems/137/ |
This commit restructures the Application Interaction chapter according to OpenEdu methodology. Signed-off-by: Iacobai Cosmin-Andrei <[email protected]>
1335ee2
to
e65aac4
Compare
Prerequisite Checklist
Description of changes
I will attempt to continue working on:
#76