Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admitted functions in MLKEM #577

Open
mamonet opened this issue Sep 14, 2024 · 3 comments · May be fixed by #713
Open

Admitted functions in MLKEM #577

mamonet opened this issue Sep 14, 2024 · 3 comments · May be fixed by #713
Assignees
@karthikbhargavan

Comments

@mamonet
Copy link
Member

mamonet commented Sep 14, 2024 •
edited
Loading

This issue lists the admitted functions in libcrux MLKEM code to be resolved

  1. to_spec_poly_t in generic polynomial.rs https://github.com/cryspen/libcrux/blob/dev/libcrux-ml-kem/src/polynomial.rs#L28-L31
  2. zetas_b_lemma in generic ntt.rs/invert_ntt.rs https://github.com/cryspen/libcrux/blob/ntt-panic-free/libcrux-ml-kem/src/ntt.rs#L8-L10 (The code is part of Make ntt panic free #576) [This one removed]
@github-actions GitHub Actions
Copy link

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added stale and removed stale labels Nov 14, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Jan 15, 2025
@karthikbhargavan
Copy link
Contributor

This is indeed stale, should be already closed or closed once #713 is merged.

@franziskuskiefer franziskuskiefer linked a pull request Jan 15, 2025 that will close this issue
Make more modules panic free #713
Draft
@github-actions github-actions bot removed the stale label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karthikbhargavan karthikbhargavan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make more modules panic free cryspen/libcrux
2 participants
@karthikbhargavan @mamonet