Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Continuous integration #36

Open
AliSajid opened this issue Sep 21, 2022 · 5 comments
Open

Add Continuous integration #36

AliSajid opened this issue Sep 21, 2022 · 5 comments

Comments

@AliSajid
Copy link
Contributor

I have a pretty decent CI System built in my tool repo. The actual tool is pretty simple but I have a few things running that:

  1. Run a few pre-commit hooks before I commit
  2. Ensure that the commit messages conform to the Conventional Commit standard
  3. Runs a matrix build across four rust toolchains across three operating systems (linux, windows, macos)
  4. Runs the Semantic Release action to see if a new release is needed and if yes, which version marker to bump
  5. Creates a new release if necessary.
  6. Runs a build across the three operating systems and then uploads build artifacts to the release page.

I'd be happy to implement that in this in here.

@crumblingstatue
Copy link
Owner

I'm not sure I want to use semantic releases and conventional commits.
We already have a CHANGELOG, adhering to keep a changelog, which allows more freedom of expression than an automatically generated changelog.
Similarly, I feel like adhering too closely to a standard in commit messages just creates friction.
So for now, I don't want to commit to using either of these conventions.

CI would however be great for testing, but right now it would require set up for SFML, which I am going to try to transition away from before 0.2.0.

I'm gonna try to wait with CI until the port to wgpu+winit is complete, which will make both distribution and CI easier.

@AliSajid
Copy link
Contributor Author

I think it would be wise to wait for CI. I'd be happy to help in whatever capacity.

@crumblingstatue
Copy link
Owner

I'm gonna reopen this as a tracking issue for eventually implementing CI.

@crumblingstatue crumblingstatue added this to the 0.2 milestone Sep 21, 2022
@crumblingstatue crumblingstatue removed this from the 0.2 milestone Dec 10, 2022
@crumblingstatue
Copy link
Owner

Due to lack of time to work on this project, I'm prioritizing working on features that I want, so I'm removing this from a 0.2 milestone.
However, feel free to make a pull request for CI support.

@crumblingstatue
Copy link
Owner

There is Linux CI in place now. Gonna try to add Windows and Mac OS CI as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants