Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry GitHub job watch #90

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind ci

What this PR does / why we need it:

From time to time the job watch throws a 502 error:

failed to get jobs: HTTP 502: Server Error (https://api.github.com/repos/cri-o/packaging/actions/runs/8682352551/jobs?per_page=100)

We now retry up to three times to make the test suite robust.

Which issue(s) this PR fixes:

As follow-up, I opened: cli/go-gh#157

Special notes for your reviewer:

PTAL @cri-o/cri-o-maintainers

Does this PR introduce a user-facing change?

None

From time to time the job watch throws a 502 error:

```
failed to get jobs: HTTP 502: Server Error (https://api.github.com/repos/cri-o/packaging/actions/runs/8682352551/jobs?per_page=100)
```

We now retry up to three times to make the test suite robust. As
follow-up, I opened: cli/go-gh#157

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added release-note-none dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci labels Apr 15, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
@kwilczynski
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 083801b into cri-o:main Apr 15, 2024
29 checks passed
@saschagrunert saschagrunert deleted the retry-watch branch April 15, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants