Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Deprecate Indy credentials and add support for Anoncreds #697

Open
26 tasks done
vivekayanworks opened this issue May 2, 2024 · 2 comments · May be fixed by #712
Open
26 tasks done

refactor: Deprecate Indy credentials and add support for Anoncreds #697

vivekayanworks opened this issue May 2, 2024 · 2 comments · May be fixed by #712
Assignees
Labels
enhancement New feature or request

Comments

@vivekayanworks
Copy link
Contributor

vivekayanworks commented May 2, 2024

Currently, we have Indy based credentials that are made default for issuance and verification.

To do:

  • Improve DTO level formating by leveraging APIExtraModels

  • [̶ ]̶ C̶h̶e̶c̶k̶ i̶f̶ w̶e̶ c̶a̶n̶ m̶i̶g̶r̶a̶t̶e̶ f̶r̶o̶m̶ I̶n̶d̶y̶ c̶r̶e̶d̶e̶n̶t̶i̶a̶l̶s̶ t̶o̶ A̶n̶o̶n̶c̶r̶e̶d̶s̶

  • Issuance

    • Add Anoncreds as an additional type
    • Remove credentialType from Query param and make it required in Body
    • Update credentialFormats in Interface
    • Update the default credential type from Indy to Anoncreds
      • Issuance with connection
      • OOB Issuance
      • OOB Issuance with email
      • Bulk issuance change, if any
    • Change in IssuanceDTO to accept a universal 'credentialFormats' instead of previous components required for issuing different types of credentials
      • Issuance with connection
      • OOB Issuance
      • OOB Issuance with email
      • Bulk issuance change, if any
  • Verification

    • Add Anoncreds as an additional type.
    • Add Indy 'CredentialFormats' type
    • Remove presentationType from Query param and make it required in Body
    • Update credentialFormats in Interface
    • Update the default presentation type from Indy to Anoncreds
      • Verification with connection
      • Verification OOB
    • Change in VerificationDTO to accept a universal 'credentialFormats' instead of previous components required for issuing different types of credentials.
      • Verification with connection
      • Verification OOB

Breaking change

  1. Can have an impact on required attributes for issuance and verification. The impact will be on backend considering the change in credentialFormats.

Solution

  1. Have validations on attributes on DTO level for credentialFormats to not allow issuance in case of no attributes.
  2. Can pass an optional array of required attributes, to validate.
@vivekayanworks
Copy link
Contributor Author

Check if we can migrate from Indy credentials to Anoncreds

@GHkrishna GHkrishna added the enhancement New feature or request label May 12, 2024
@GHkrishna GHkrishna linked a pull request May 12, 2024 that will close this issue
@GHkrishna GHkrishna linked a pull request May 12, 2024 that will close this issue
@sairanjit sairanjit changed the title feat: Deprecate Indy credentials and add support for Anoncreds refactor: Deprecate Indy credentials and add support for Anoncreds May 20, 2024
@GHkrishna
Copy link
Contributor

The task is done, but was not merged as it breaked other flows.

We need to create a separate task for integrating this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants