Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pars escaped surrogate pairs #32

Closed
fiserro opened this issue Apr 21, 2017 · 5 comments
Closed

Allow pars escaped surrogate pairs #32

fiserro opened this issue Apr 21, 2017 · 5 comments

Comments

@fiserro
Copy link

fiserro commented Apr 21, 2017

Surrogate pairs are parsed as two 16bit chars instead of one 32bit char.
For example this Json contains two 32bit emojis:
[ { "id" : "1", "message" : "\uD83D\uDE0B\uD83C\uDF70" } ]

We'r using java faster xml lib on one side FasterXML/jackson-core#223 and nodejs jsonparse on the other side.

There is a diff with fix:
diff.txt

@fiserro
Copy link
Author

fiserro commented Apr 25, 2017

I can make a clean pull request. The diff is just for inspiration how to solve it.
@creationix

@creationix
Copy link
Owner

Could you please make a pull request? Thanks.

@fiserro
Copy link
Author

fiserro commented Apr 28, 2017

#33 @creationix

@fiserro fiserro changed the title Allow parsing escaped surrogate pairs Allow pars escaped surrogate pairs Apr 28, 2017
@fiserro
Copy link
Author

fiserro commented May 9, 2017

@creationix Thanks for merge #33. When we can expect the new version?

@creationix
Copy link
Owner

It's live! Published to github and npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants