Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Filesystems not created during migration process from Craft 3 to Craft 4 #16407

Closed
jpcarpenter opened this issue Jan 9, 2025 · 3 comments

Comments

@jpcarpenter
Copy link

jpcarpenter commented Jan 9, 2025

What happened?

Description

Asset filesystems silently fail to be created during the migration process from Craft 3 to Craft 4. This causes other issues with other plugins, such as Redactor/CKEditor. After converting Redactor fields to ckeditor after the migration process, the redactor fields which had asset volume settings configured are lost within the newly converted ckeditor fields due to the absence of filesystems. I found this stack overflow post which describes this exact scenario, but it unfortunately doesn't have any solutions.

Steps to reproduce

  1. Follow update steps outlined in the docs.
  2. After running php craft migrate/all, asset filesystems silently fail to be created, ragardless of the fact if the two cases that may require your attention don't apply.
  3. Install CKEditor plugin
  4. Run php craft ckeditor/convert/redactor
  5. The asset volume settings for converted Redactor fields are completely removed after conversion.
  6. Additional: Notice some converted redactor fields within matrix fields are missing content

Expected behavior

The migration process should take care of volume migrations.

Actual behavior

The migration process does not take care of volume migrations, and silently fails to log any type of error during the failure.

Craft CMS version

Craft CMS 3.9.4 /Craft CMS 4.13.9

PHP version

8.3.6

Operating system and version

Linux 5.4.0-126-generic

Database type and version

MySQL 8.0.40

Image driver and version

No response

Installed plugins and versions

"craftcms/ckeditor": "^3.10.0",
"craftcms/redactor": "2.10.12",
"carlcs/craft-redactorcustomstyles": "3.0.4",
"craftcms/cms": "^4.0.0",
"hybridinteractive/craft-position-fieldtype": "^4.0.0",
"nystudio107/craft-imageoptimize": "^4.0.10",
"nystudio107/craft-routemap": "^4.0.1",
"nystudio107/craft-seomatic": "^4.1.8",
"ostark/craft-async-queue": "^3.2.1",
"sebastianlenz/linkfield": "2.*@rc",
"spicyweb/craft-neo": "^4.2.23",
"spicyweb/craft-odds-and-ends": "^4.3.1",
"vaersaagod/matrixmate": "^2.2.2",
"verbb/field-manager": "^3.0.9",
"verbb/formie": "^2.1",
"verbb/hyper": "^1.3",
"verbb/navigation": "^2.1.1",
"verbb/super-table": "^3.0.15",
"vlucas/phpdotenv": "^5.4.0"

@i-just
Copy link
Contributor

i-just commented Jan 10, 2025

Hi, thanks for getting in touch! Could you please send your composer.json, composer.lock and database export from before the upgrade and composer.json and composer.lock from after the upgrade to [email protected] so that we can try to reproduce and dig deeper?

@jpcarpenter
Copy link
Author

jpcarpenter commented Jan 10, 2025

Hey @i-just, thanks for the response! I've since unintentionally found a fix to the filesystem issue. Turns out there were deprecated syntax located within my general.php file. Once I addressed those, then ran the migration, filesystems were automatically created. Let me know however if you would still like me to send over the items you requested.

There is still one related issue that I mentioned in the "Steps To Reproduce" section of my original post that seems to be exacerbated now. This relates to "Additional: Notice some converted redactor fields within matrix fields are missing content". All ckeditor fields within matrix blocks seem to be missing content after running php craft ckeditor/convert/redactor. I've found a post about this same issue on the ckeditor repo, and have added my comments there, but let me know if you would like any additional information regarding this.

@i-just
Copy link
Contributor

i-just commented Jan 13, 2025

Thanks for the update. I’m glad to hear the filesystems are created as expected!

I commented on the CKEditor conversion issue in the CKEditor repo.

@i-just i-just closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants