Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InValueSetEvaluator and AnyInValueset return null when a passed in code is null, contrary to the current cql spec #1469

Closed
Zylox opened this issue Dec 13, 2024 · 2 comments
Assignees
Labels

Comments

@Zylox
Copy link
Contributor

Zylox commented Dec 13, 2024

Looking through the version history, returning null in this case was the spec at one point. The last reference i could find to that was in STU2: https://cql.hl7.org/STU2/09-b-cqlreference.html#in-valueset

Since the version below however, the spec says it should return false in the situation where the code is null: https://cql.hl7.org/2018May/09-b-cqlreference.html#in-valueset

The effected areas, to the best of my knowledge, would be here: https://github.com/cqframework/clinical_quality_language/blob/master/Src/java/engine/src/main/java/org/opencds/cqf/cql/engine/elm/executing/InValueSetEvaluator.java#L26-L28

and here: https://github.com/cqframework/clinical_quality_language/blob/master/Src/java/engine/src/main/java/org/opencds/cqf/cql/engine/elm/executing/AnyInValueSetEvaluator.java#L16

The change itself would be minor, but the effect could be larger. Though it would seemingly be more in line with the cql spec.

@JPercival
Copy link
Contributor

Thanks for the report! Related to #1048

@JPercival JPercival added the bug label Dec 13, 2024
@JPercival JPercival self-assigned this Dec 13, 2024
@JPercival
Copy link
Contributor

Most recent published spec: https://cql.hl7.org/09-b-cqlreference.html#in-valueset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants