Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internet.endpoint.extensible] condition too long to fit on one line #64

Open
jwakely opened this issue Mar 20, 2017 · 0 comments
Open

Comments

@jwakely
Copy link
Member

jwakely commented Mar 20, 2017

This runs into the right margin:

Remarks: length_error if the condition protocol().family() == AF_INET6 && s != sizeof(sock- addr_in6) || protocol().family() == AF_INET4 && s != sizeof(sockaddr_in) is true.

It could be changed to:

Remarks: length_error if either of the following conditions is true:
— protocol().family() == AF_INET6 && s != sizeof(sockaddr_in6),
— protocol().family() == AF_INET4 && s != sizeof(sockaddr_in).

But maybe it could be:

Remarks: length_error if s != size().

This isn't identical in the case where protocol.family() is neither AF_INET4 not AF_INET6 but that should be disallowed by the constructors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant