Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cow-shed module (#2) #219

Merged
merged 15 commits into from
Sep 23, 2024
Merged

Add cow-shed module (#2) #219

merged 15 commits into from
Sep 23, 2024

Conversation

yvesfracari
Copy link
Contributor

  • add cow shed related abi and move contracts codegen folder to common

  • add initial cow shed package

  • add tests to the cow-shed module

  • add wip comments

  • chore(examples): add local cow sdk version to cra example

  • feat(examples): add generate cow shed hook calldata

  • revert ethers version change

  • improve bigint readability


yvesfracari and others added 9 commits August 30, 2024 15:05
* add cow shed related abi and move contracts codegen folder to common

* add initial cow shed package

* add tests to the cow-shed module

* add wip comments

* chore(examples): add local cow sdk version to cra example

* feat(examples): add generate cow shed hook calldata

* revert ethers version change

* improve bigint readability

---------

Co-authored-by: José Ribeiro <[email protected]>
Copy link

github-actions bot commented Sep 4, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

socket-security bot commented Sep 4, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Protestware or potentially unwanted behavior npm/[email protected]
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale
⚠︎

View full report↗︎

Next steps

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package may come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

src/common/consts.ts Outdated Show resolved Hide resolved
Copy link

Report too large to display inline

View full report↗︎

@ribeirojose
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@yvesfracari yvesfracari marked this pull request as ready for review September 18, 2024 12:57
@yvesfracari
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@shoom3301
Copy link
Contributor

@yvesfracari hi!
Tests are failing:

FAIL src/cow-shed/CoWShedHooks.spec.ts
  ● Test suite failed to run

    Cannot find module './CowShedHooks' from 'src/cow-shed/CoWShedHooks.spec.ts'

      1 | import { Wallet } from 'ethers'
    > 2 | import { CowShedHooks } from './CowShedHooks'

@shoom3301 shoom3301 merged commit f07d2d6 into cowprotocol:main Sep 23, 2024
4 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants