Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: returns appDataHash #193

Open
mfw78 opened this issue Jan 4, 2024 · 1 comment
Open

bug: returns appDataHash #193

mfw78 opened this issue Jan 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mfw78
Copy link
Contributor

mfw78 commented Jan 4, 2024

Problem

A typedoc issue: https://github.com/cowprotocol/cow-sdk/blame/c73a93e2a4ba056611413b56210a77554b289b10/src/order-book/api.ts#L339.

Solution

This API actually returns the appDataHash and should be annotated as such.

@mfw78 mfw78 added the bug Something isn't working label Jan 4, 2024
@mfw78
Copy link
Contributor Author

mfw78 commented Jan 5, 2024

Further to this:

uploadAppData returns an AppDataObject but AppDataObject has fullAppData, but the uploadAppData only returns the appDataHash (from the actual API), whereas the getAppData returns an AppDataObject which actually contains the fullAppData document (ie. the JSON-stringified version of the app data document).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant