Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 6.0.1 breaks with multiple exclude-by-attribute parameters #1624

Closed
david-beckman opened this issue Feb 21, 2024 · 3 comments · Fixed by #1627
Closed

[BUG] 6.0.1 breaks with multiple exclude-by-attribute parameters #1624

david-beckman opened this issue Feb 21, 2024 · 3 comments · Fixed by #1627
Labels
bug Something isn't working

Comments

@david-beckman
Copy link

david-beckman commented Feb 21, 2024

Describe the bug
Starting with 6.0.1, multiple exclude-by-attribute parameters results in an error

To Reproduce
coverlet.exe $testFile --target "dotnet" --format "covertura" --exclude-by-attribute "Obsolete" --exclude-by-attribute "GeneratedCode" --exclude-by-attribute "CompilerGenerated"

Expected behavior
Any of the matching attributes are excluded from the coverage results.

Actual behavior
The exe fails returning Option '--exclude-by-attribute' expects a single argument but 3 were provided.
NOTE: running the same command on 6.0.0 succeeds

Configuration (please complete the following information):
Please provide more information on your .NET configuration:
* Which coverlet package and version was used?
6.0.1
* Which version of .NET is the code running on?
dotnet sdk 8.0.200
* What OS and version, and what distro if applicable?
Windows Server 2022
* What is the architecture (x64, x86, ARM, ARM64)?
x64
* Do you know whether it is specific to that configuration?
Does not appear to be - I can replicate on Linux x64

Additional context
(none)

@github-actions github-actions bot added the untriaged To be investigated label Feb 21, 2024
@huideaki
Copy link

Same issue found on 6.0.1 on our side

Option '--exclude-by-attribute' expects a single argument but 2 were provided.

@khoait
Copy link

khoait commented Feb 21, 2024

having the same issue with 6.0.1

@daveMueller
Copy link
Collaborator

daveMueller commented Feb 22, 2024

We changed the used cli framework for coverlet.console but tried not to make a breaking change. Unfortunately this slipped us. The linked PR will fix it. Thanks for reporting. 🙏

@daveMueller daveMueller added bug Something isn't working and removed untriaged To be investigated labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants