From 204c1d1a36b9982673d0d31a39ac9ff696e70975 Mon Sep 17 00:00:00 2001 From: Jun Kimura Date: Wed, 4 Dec 2024 22:13:42 +0900 Subject: [PATCH 1/3] fix to remove the outdated description for optimistic send Signed-off-by: Jun Kimura --- spec/core/ics-004-channel-and-packet-semantics/README.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/spec/core/ics-004-channel-and-packet-semantics/README.md b/spec/core/ics-004-channel-and-packet-semantics/README.md index acd6ad7b6..b31950be9 100644 --- a/spec/core/ics-004-channel-and-packet-semantics/README.md +++ b/spec/core/ics-004-channel-and-packet-semantics/README.md @@ -1154,8 +1154,6 @@ In the case of an unordered channel, `timeoutPacket` checks the absence of the r If relations are enforced between timeout heights of subsequent packets, safe bulk timeouts of all packets prior to a timed-out packet can be performed. This specification omits details for now. -Since we allow optimistic sending of packets (i.e. sending a packet before a channel opens), we must also allow optimistic timing out of packets. With optimistic sends, the packet may be sent on a channel that eventually opens or a channel that will never open. If the channel does open after the packet has timed out, then the packet will never be received on the counterparty so we can safely timeout optimistically. If the channel never opens, then we MUST timeout optimistically so that any state changes made during the optimistic send by the application can be safely reverted. - We pass the `relayer` address just as in [Receiving packets](#receiving-packets) to allow for possible incentivization here as well. ```typescript From 1a167be23b903a5c5e862b45b4db3947ee7f6bc3 Mon Sep 17 00:00:00 2001 From: Jun Kimura Date: Wed, 4 Dec 2024 22:15:57 +0900 Subject: [PATCH 2/3] fix to clarify channel state for sending packet Signed-off-by: Jun Kimura --- spec/core/ics-004-channel-and-packet-semantics/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/core/ics-004-channel-and-packet-semantics/README.md b/spec/core/ics-004-channel-and-packet-semantics/README.md index b31950be9..bcc6f22d3 100644 --- a/spec/core/ics-004-channel-and-packet-semantics/README.md +++ b/spec/core/ics-004-channel-and-packet-semantics/README.md @@ -742,7 +742,7 @@ Calling modules MUST execute application logic atomically in conjunction with ca The IBC handler performs the following steps in order: -- Checks that the channel is not closed to send packets +- Checks that the channel is opened to send packets - Checks that the calling module owns the sending port (see [ICS 5](../ics-005-port-allocation)) - Checks that the timeout height specified has not already passed on the destination chain - Increments the send sequence counter associated with the channel From be6bd7d57f7abb357e69b4265e795948ab7f85a6 Mon Sep 17 00:00:00 2001 From: Jun Kimura Date: Thu, 5 Dec 2024 00:41:09 +0900 Subject: [PATCH 3/3] update history in ics-004 Signed-off-by: Jun Kimura --- spec/core/ics-004-channel-and-packet-semantics/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spec/core/ics-004-channel-and-packet-semantics/README.md b/spec/core/ics-004-channel-and-packet-semantics/README.md index bcc6f22d3..1590d51c4 100644 --- a/spec/core/ics-004-channel-and-packet-semantics/README.md +++ b/spec/core/ics-004-channel-and-packet-semantics/README.md @@ -1537,6 +1537,8 @@ Jan 10, 2022 - Add ORDERED_ALLOW_TIMEOUT channel type and appropriate logic Mar 28, 2023 - Add `writeChannel` function to write channel end after executing application callback +Dec 4, 2024 - Remove the description for optimistic packet sending + ## Copyright All content herein is licensed under [Apache 2.0](https://www.apache.org/licenses/LICENSE-2.0).