Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Inconsistency between Cosmos SDK v2 and Protocol Buffer versions causing integration challenges #23441

Closed
TraderWithPython opened this issue Jan 17, 2025 · 1 comment

Comments

@TraderWithPython
Copy link

Summary

While the upgrade to Cosmos SDK v2 is a welcome improvement, there's a concerning inconsistency in Protocol Buffer versions that creates unnecessary complexity in implementations.

Problem Definition

Services still rely on Protocol Buffer v1 API
ORM only supports Protocol Buffer v2 API
This forces developers to implement inelegant wrapper solutions to handle v1 <-> v2 conversions

Proposed Feature

Issue #17840 mentions that tx and query services can use Protocol Buffer v2, but I haven't found any concrete examples of this implementation.

Questions:

Is there official guidance on using Protocol Buffer v2 with tx and query services?
Are there any example implementations available?
Is there a planned timeline to fully migrate services to Protocol Buffer v2?
This version mismatch significantly impacts development efficiency and code elegance. Clear documentation or migration guides would be helpful for the community.

Related: #17840

@julienrbrt
Copy link
Member

Hi! You should consider and protobuf v1 as the one to use in the state machine.
ORM is a bit the odd kid right now, and I would advice you to use cosmossdk.io/collections instead.
We attempted to bring a good experience with protobuf v2, but eventually we decided that sticking with cosmos/gogoproto due to the complexity and subpar UX it created.

You should still be able to have clients using protobuf v2 without an issue however.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🥳 Done
Development

No branches or pull requests

2 participants