[Bug]: Cannot update Validator Description Metadata

[corverroos]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

While reading through the MsgEditValidator logic, I noticed a bug introduced in PR #21315 in x/staking/types/validator.go#Description.UpdateDescription.

The bug results in Metadata never being updated.

The code in question is:

	if d2.Metadata.ProfilePicUri == DoNotModifyDesc {
		d2.Metadata.ProfilePicUri = d.Metadata.ProfilePicUri
	}

	return NewDescription(
		d2.Moniker,
		d2.Identity,
		d2.Website,
		d2.SecurityContact,
		d2.Details,
		d.Metadata, <- bug is here
	).Validate()

The problem is that d.Metadata is used in NewDescription instead of d2.Metadata.

Cosmos SDK Version

v1.0.0

How to reproduce?

Submit an MsgEditValidator that modifies any of the two Description.Metadata fields, see that they are ignored.