Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: x/upgrade ParseInfo consider some values as URLs #19686

Closed
1 task done
mhofman opened this issue Mar 7, 2024 · 4 comments · Fixed by #19706
Closed
1 task done

[Bug]: x/upgrade ParseInfo consider some values as URLs #19686

mhofman opened this issue Mar 7, 2024 · 4 comments · Fixed by #19706
Labels
T:Bug

Comments

@mhofman
Copy link

mhofman commented Mar 7, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Trying to use values such as {} for upgrade-info results in error missing checksum query parameter.

The problem is that ParseInfo attempts to parse the upgrade info as a URL and consider it as such if no error is returned. However most strings can parse as a valid URL, especially relative ones.

It should at least check that the URL is absolute.

Cosmos SDK Version

0.46

How to reproduce?

$ gaiad tx gov submit-proposal software-upgrade foo --upgrade-height 123 --upgrade-info '{}'
Error: missing checksum query parameter
@mhofman mhofman added the T:Bug label Mar 7, 2024
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Mar 7, 2024
@aj-agoric aj-agoric mentioned this issue Mar 7, 2024
Closed
@gibson042
Copy link
Contributor

The simplest fix is replacing Parse with ParseRequestURI: agoric-labs#405

@julienrbrt
Copy link
Member

The simplest fix is replacing Parse with ParseRequestURI: agoric-labs#405

Cool! Are you willing to submit a PR?

@julienrbrt
Copy link
Member

Error: missing checksum query parameter

FWIW, you can skip the upgrade info checks with a flag

@gibson042 gibson042 mentioned this issue Mar 8, 2024
Merged
12 tasks
@gibson042
Copy link
Contributor

Cool! Are you willing to submit a PR?

#19706

gibson042 added a commit to gibson042/cosmos-sdk that referenced this issue Mar 8, 2024
@gibson042
fix(x/upgrade): Stop treating inline JSON as a URL
892c4e4 
Fix cosmos#19686
julienrbrt added a commit to gibson042/cosmos-sdk that referenced this issue Mar 16, 2024
@julienrbrt
Merge branch 'main' into cosmosgh-19686-parseinfo-url-detection
1c7741e
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Mar 16, 2024
@mergify mergify bot mentioned this issue Mar 16, 2024
Merged
12 tasks
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(x/upgrade): Stop treating inline JSON as a URL gibson042/cosmos-sdk
3 participants
@mhofman @gibson042 @julienrbrt