Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes use huge amount of metadata #16

Open
sfan5 opened this issue Sep 10, 2016 · 2 comments
Open

Nodes use huge amount of metadata #16

sfan5 opened this issue Sep 10, 2016 · 2 comments

Comments

@sfan5
Copy link

sfan5 commented Sep 10, 2016

A single craftguide node uses about 32k bytes of metadata through it's inventory. Every single obtainable node/item seems to be stored in the main list.

Found while investigating @IhrFussel lag issues and the reason for big MapBlocks

@cornernote
Copy link
Owner

Ouch. Not sure what to do. I think a replacement for this mod is in order, really needs a rebuild from the ground up. Unfortunately I don't have time to undertake such a task any time soon.

@Miner59
Copy link
Collaborator

Miner59 commented Dec 4, 2016

Yeah, seems a pretty big issue.
I think most newer craft guide mods use lists with buttons instead of inventories.
But this would mean bookmarks are harder to use, because you can't just pull items around. You would need additional buttons for adding to bookmarks and to delete them again.
Also I don't want to look everything the same because I find it boring when all craft guide mods look basically the same.
So instead I think I try to code something to save only the items on the page you are currently watching in the main inventory. Would be still a bit of work, but should be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants