-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not Compatible With New Method "minetest.clear_craft()" #15
Comments
This was my first mod, and it got really messy. It hasn't helped the state of the code that others have furthered development of the code while I haven't been available. If you're able to fix please send a pull request, otherwise I'm afraid I don't have time to manage this mod. |
It could be fixed by creating the craft list not when minetest.register_craft is executed but when the first time someone right clicks the guide node, can't it? Are crafting recipes of mods loaded before this mod added to the guide? |
I haven't looked at the code closely, but the craft_guide has to be loaded before the mod registering crafts else they won't be listed in the guide. There is a function minetest.get_all_craft_recipes (http://dev.minetest.net/minetest.get_all_craft_recipes) that I think would work for loading recipes when clicking the guide. If I get it figured out, I'll send a pull request, though I am new to GitHub and the whole pull requests thing. |
There is another mod called "craftguide" (https://forum.minetest.net/viewtopic.php?t=14088) by jp that works a bit differently. But it has some issues with not listing some of the registered crafts I think. Not sure exactly how it works either. |
In the current development version of Minetest, there is a new method minetest.clear_craft(). This method removes a registered craft recipe from the game. However, the craft_guide's list of recipes is unaffected. So crafts that have actually been removed still display in the craft_guide.
Would be nice to have it updated for compatibility.
The text was updated successfully, but these errors were encountered: