Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace chrono::DateTime #31

Open
coord-e opened this issue May 16, 2022 · 4 comments
Open

Replace chrono::DateTime #31

coord-e opened this issue May 16, 2022 · 4 comments

Comments

@coord-e
Copy link
Owner

coord-e commented May 16, 2022

https://doc.rust-lang.org/std/time/struct.SystemTime.html
@coord-e coord-e added this to the 0.3.0 milestone May 16, 2022
@coord-e
Copy link
Owner Author

coord-e commented May 19, 2022

Some considerations:

  • RFC 3339 parsing
  • ergonomics - maybe we should consider Into<SystemTime>

@coord-e
Copy link
Owner Author

coord-e commented May 19, 2022

Maybe it is ISO8601 instead of RFC3339, but in any case, the problem is not parsing but conversion to SystemTime, which may lead us to depend on time-rs anyway...

@coord-e
Copy link
Owner Author

coord-e commented May 19, 2022

having distinct date-time type (which does not convert to SystemTime) for ISO8601-encoded date-time field in -api and provide conversion to time::OffsetDateTime in -util would be nice

@coord-e coord-e changed the title Replace chrono::DateTime with std::time::SystemTime Replace chrono::DateTime May 19, 2022
@coord-e
Copy link
Owner Author

coord-e commented Oct 26, 2022

This is no longer such a serious problem as chrono has been back in maintenance since 0.4.20.

@coord-e coord-e removed this from the 0.3.0 milestone Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coord-e