fix: implement type safety fallback

[Lelith]

With some package update, typescript errors got interpreted as more strict. This implements the slug handling in a typesafe way with fallbacks.

[changeset-bot]

⚠️ No Changeset found

Latest commit: d11f581

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
forma-36	✅ Ready (Inspect)	Visit Preview	Nov 12, 2024 8:43am

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
CommonJS	112.03 KB (0%)	2.3 s (0%)	262 ms (+59.35% 🔺)	2.6 s
Module	110.84 KB (0%)	2.3 s (0%)	306 ms (+79.52% 🔺)	2.6 s

[denkristoffer]

Do these exist?

[Lelith]

they usually are never undefined, but the type script error is now blocking the build, so i implemented a quick fallback to avoid the error.
the issue is that neither item nor section are properly typed and so this is the point where it falls trough. i can also go ahead and do a wider refactoring, fixing the initial types. but as all builds are failing at the moment, i wanted to have a quick fix.

[denkristoffer]

I mean do these default sections and items exist or would something break if they actually got used?

[Lelith]

Ahh, no, just the slug name and item would be displayed like that.

[denkristoffer]

Okay. I would like to understand what broke and why now, but we can get a hotfix in first.

[cf-remylenoir]

Are we able to pinpoint what package bump caused this regression?
Looking at the latest merged pull requests, I see that they were successful.

[Lelith]

@denkristoffer @cf-remylenoir i am also not sure, i was trying it out with the latest master where it failed immediately. and also versions above, so maybe its not an update in this package but one on circle ci? i mean its "just" a linter issue, so it seems like it could be based on some node or npm version or something like that.