Add Header / Layout components #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a0c8e64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
cdun
force-pushed
the
feat/CFCX-540_forma-layout
branch
2 times, most recently
from
4e31ce6
to
46890f4
Compare
cdun
force-pushed
the
feat/CFCX-540_forma-layout
branch
from
46890f4
to
123ae99
Compare
mshaaban0
approved these changes
Aug 4, 2023
| ref: Ref<HTMLButtonElement>, | ||
| ) { | ||
| return ( | ||
| <Button |
There was a problem hiding this comment.
Should this be an IconButton?
cdun
force-pushed
the
feat/CFCX-540_forma-layout
branch
from
123ae99
to
3ef19cc
Compare
massao
approved these changes
Aug 4, 2023
| @@ -0,0 +1,51 @@ | |||
| --- | |||
| title: 'Header' | |||
| type: 'component' | |||
There was a problem hiding this comment.
Maybe they should be on the Layout section??
Suggested change
| type: 'component' | |
| type: 'component' | |
| section: 'layoutComponents' |
| '@contentful/f36-image': '^4.0.0-alpha.0', // Remove when added to f36-components | ||
| '@contentful/f36-layout': '^4.0.0-alpha.0', // Remove when added to f36-components |
There was a problem hiding this comment.
We need to start moving things to the f36-components... 😅
| @@ -0,0 +1,31 @@ | |||
| --- | |||
| title: 'Layout' | |||
| type: 'component' | |||
Adds an alpha implementation of the Layout component
cdun
force-pushed
the
feat/CFCX-540_forma-layout
branch
from
3ef19cc
to
a0c8e64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
Introduces alpha versions of
HeaderandLayoutcomponentsPR Checklist
readme.mdfile(s)