-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
podman-remote exec detach broken #25089
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
Jan 22, 2025
podman exec support detaching early via the detach key sequence. In that case the podman process should exit successfully but the container exec process keeps running. Given that I could not find any existing test for the detach key functionality not even for exec I added some. This seems to reval more issues with on podman-remote, podman-remote run detach was broken which I fixed here as well but for podman-remote exec something bigger is needed. While I thought I fixed most problems there there was a strange raqce condition which caused the process to jung hang. Thus I skipped the remote exec test for now and filled containers#25089 to track that. Fixes containers#24895 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
Jan 22, 2025
podman exec support detaching early via the detach key sequence. In that case the podman process should exit successfully but the container exec process keeps running. Given that I could not find any existing test for the detach key functionality not even for exec I added some. This seems to reveal more issues with on podman-remote, podman-remote run detach was broken which I fixed here as well but for podman-remote exec something bigger is needed. While I thought I fixed most problems there there was a strange race condition which caused the process to just hang. Thus I skipped the remote exec test for now and filled containers#25089 to track that. Fixes containers#24895 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
Jan 22, 2025
podman exec support detaching early via the detach key sequence. In that case the podman process should exit successfully but the container exec process keeps running. Given that I could not find any existing test for the detach key functionality not even for exec I added some. This seems to reveal more issues with on podman-remote, podman-remote run detach was broken which I fixed here as well but for podman-remote exec something bigger is needed. While I thought I fixed most problems there there was a strange race condition which caused the process to just hang. Thus I skipped the remote exec test for now and filled containers#25089 to track that. Fixes containers#24895 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
Jan 22, 2025
podman exec support detaching early via the detach key sequence. In that case the podman process should exit successfully but the container exec process keeps running. Given that I could not find any existing test for the detach key functionality not even for exec I added some. This seems to reveal more issues with on podman-remote, podman-remote run detach was broken which I fixed here as well but for podman-remote exec something bigger is needed. While I thought I fixed most problems there there was a strange race condition which caused the process to just hang. Thus I skipped the remote exec test for now and filled containers#25089 to track that. Fixes containers#24895 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
Jan 22, 2025
podman exec support detaching early via the detach key sequence. In that case the podman process should exit successfully but the container exec process keeps running. Given that I could not find any existing test for the detach key functionality not even for exec I added some. This seems to reveal more issues with on podman-remote, podman-remote run detach was broken which I fixed here as well but for podman-remote exec something bigger is needed. While I thought I fixed most problems there there was a strange race condition which caused the process to just hang. Thus I skipped the remote exec test for now and filled containers#25089 to track that. Fixes containers#24895 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
Jan 24, 2025
podman exec support detaching early via the detach key sequence. In that case the podman process should exit successfully but the container exec process keeps running. Given that I could not find any existing test for the detach key functionality not even for exec I added some. This seems to reveal more issues with on podman-remote, podman-remote run detach was broken which I fixed here as well but for podman-remote exec something bigger is needed. While I thought I fixed most problems there there was a strange race condition which caused the process to just hang. Thus I skipped the remote exec test for now and filled containers#25089 to track that. Fixes containers#24895 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
Jan 31, 2025
podman exec support detaching early via the detach key sequence. In that case the podman process should exit successfully but the container exec process keeps running. Now I wrote automated test for both podman run and exec detach but this uncovered several larger issues: - detach sequence parsing is broken[1] - podman-remote exec detach is broken[2] - detach in general seems to be buggy/racy, seeing lot of flakes that fail to restore the terminal and get an EIO instead, i.e. "Unable to restore terminal: input/output error" Thus I cannot add tests for now but this commit should at least fix the obvoius case as reported by the user so I like to get this in regardless and I will work through the other issues once I have more time. Fixes containers#24895 [1] containers/common#2302 [2] containers#25089 Signed-off-by: Paul Holzinger <[email protected]>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/podman
that referenced
this issue
Feb 3, 2025
podman exec support detaching early via the detach key sequence. In that case the podman process should exit successfully but the container exec process keeps running. Now I wrote automated test for both podman run and exec detach but this uncovered several larger issues: - detach sequence parsing is broken[1] - podman-remote exec detach is broken[2] - detach in general seems to be buggy/racy, seeing lot of flakes that fail to restore the terminal and get an EIO instead, i.e. "Unable to restore terminal: input/output error" Thus I cannot add tests for now but this commit should at least fix the obvoius case as reported by the user so I like to get this in regardless and I will work through the other issues once I have more time. Fixes containers#24895 [1] containers/common#2302 [2] containers#25089 Signed-off-by: Paul Holzinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
podman-remote exec -it comectr sh
does not properly detach without error.with exit code 255
I tried to fix it #25083 but gave up as there are some race conditions where it all of the sudden hangs. Just filing so I can skip the test on remote and refer to this issue so it is not forgotten.
It is currently broken on main and in the PR.
The text was updated successfully, but these errors were encountered: