Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Annotations in Traits are ignored #240

Open
ribeirobreno opened this issue Sep 23, 2021 · 3 comments
Open

[BUG] Annotations in Traits are ignored #240

ribeirobreno opened this issue Sep 23, 2021 · 3 comments

Comments

@ribeirobreno
Copy link

This is regarding a backwards incompatible change introduced at #237
As an workaround, avoid version 4.3.2 of this library.

Steps to reproduce

Create a command using a trait for common options shared among several similar commands.

Expected behavior

The command runs with no errors and the options are accepted.

Actual behavior

The options defined at the trait are completely ignored.

System Configuration

Any
@greg-1-anderson
Copy link
Member

Also mentioned in #234; PRs welcome.

@ribeirobreno ribeirobreno mentioned this issue Sep 23, 2021
Closed
@ribeirobreno
Copy link
Author

Done, thanks!

@Jelle-S
Copy link

Jelle-S commented Apr 4, 2022

@greg-1-anderson This BC break was re-introduced in 4.5.3.
This line: https://github.com/consolidation/annotated-command/blob/4.x/src/AnnotatedCommandFactory.php#L29
defaults to false in the 4.x branch, but defaults to true in 4.5.3

Jelle-S added a commit to district09/robo-digipolis-helpers that referenced this issue Apr 4, 2022
@Jelle-S
Add fix for BC break in Robo
15af89b 
See consolidation/annotated-command#240
Jelle-S added a commit to district09/robo-digipolis-helpers that referenced this issue Apr 4, 2022
@Jelle-S
Merge branch 'develop'
8da6895 
Merge details:

commit 15af89b
Author: Jelle Sebreghts <[email protected]>
Date:   Mon Apr 4 10:54:13 2022

    Add fix for BC break in Robo

    See consolidation/annotated-command#240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@greg-1-anderson @ribeirobreno @Jelle-S