This repository has been archived by the owner on May 28, 2021. It is now read-only.
[Node] Deposit app gets stuck for async transfers #1407
Labels
Bug
Something isn't working
p0 CRITICAL
CRITICAL bugfixes and security problems leading to potential loss of funds
There's at least one bug here:
Imagine a case where a deposit app is proposed, but then the install fails for some reason (e.g. user offline).
If this happens, an
evt timeout
will be thrown from therequestDepositRights
fn indeposit.service.ts
. Then, we'll execute thecleanUpDepositRights()
fn in the catch block. All good so far.cleanUpDepositRights()
, however, does the following:where
appIdentityHash = await this.requestDepositRights(channel, assetId);
If
appIdentityHash
is undefined (e.g. because therequestDepositRights
function itself failed), we wont do anything tocleanUpDepositRights()
here. Because the user is also offline, they won't be around torejectInstall
as per the try/catch inhandleAppProposal
in the client.Not sure where this leaves the client but we should definitely handle this case better.
The text was updated successfully, but these errors were encountered: