Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample configs format for max.interval and iterations is incorrect #95

Open
daveshook opened this issue Nov 22, 2021 · 2 comments
Open

Comments

@daveshook
Copy link

The sample configs specify max.interval and interations incorrectly, e.g., "max.interval": 100, and "iterations": 10000000,. These need to be specified as string values, e.g., "max.interval": "100", and "iterations": "10000000",.

@ybyzek
Copy link
Contributor

ybyzek commented Nov 22, 2021

@daveshook is this a difference between CCloud connector config using Confluent CLI and on-prem local connector config using curl

@daveshook
Copy link
Author

daveshook commented Nov 23, 2021

I spoke too soon. I tested on-prem local connector config using curl that included "max.interval": "100", and "iterations": "10000000",. This succeeded. Based upon my CCloud experience, I assumed using "max.interval": 100, or "iterations": 10000000, would result in an error but did not verify this. I just did a fresh test and both options work. When specifying either of these settings without the surrounding quotes, the command output shows them with surrounding quotes.

$ curl -X POST \
>   -H "Content-Type: application/json" \
>   --data '{
>   "name": "DatagenConnectorConnector_0",
>   "config": {
>     "name": "DatagenConnectorConnector_0",
>     "connector.class": "io.confluent.kafka.connect.datagen.DatagenConnector",
>     "tasks.max": "1",
>     "kafka.topic": "transactions",
>     "max.interval": 10,
>     "iterations": 10000,
>     "quickstart": "transactions"
>   }
> }' http://connect:8083/connectors
{"name":"DatagenConnectorConnector_0","config":{"name":"DatagenConnectorConnector_0","connector.class":"io.confluent.kafka.connect.datagen.DatagenConnector","tasks.max":"1","kafka.topic":"transactions","max.interval":"10","iterations":"10000","quickstart":"transactions"},"tasks":[],"type":"source"}

So the sample configs will work as is with the on-prem local connector config using curl. Their not being enclosed in quotes in the sample configs is just a nit. @ybyzek please close the issue unless you feel the nit is worthy of fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants