Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Automated payment of OC/AP members #452

Closed
pinosu opened this issue Sep 14, 2022 · 7 comments
Closed

Add support for Automated payment of OC/AP members #452

pinosu opened this issue Sep 14, 2022 · 7 comments
Assignees
Milestone

Comments

@pinosu
Copy link
Contributor

pinosu commented Sep 14, 2022

Implement blockchain part related to tc-payments contract.

TODOs:

  1. Store and instantiate this contract in the chain. That means, a contract "upgrade" proposal for tc-payments.
  2. Modify tgrade so that it calls this contract's end blocker. That means, a tgrade chain upgrade proposal.
  3. Modify valset distribution so that it sends the engagement funds to this contract instead to the engagement contract. That means, a valset contract upgrade proposal, as the distribution list is currently not part of the update config mechanism (tgrade-valset: Modify distribution list to send funds to tc-payments poe-contracts#182).
@pinosu pinosu added this to the v3.0.0 milestone Sep 14, 2022
@ueco-jb
Copy link

ueco-jb commented Sep 15, 2022

Release 0.14 of tgrade-contracts is required beforehand.

@alpe
Copy link
Contributor

alpe commented Sep 16, 2022

Modify tgrade so that it calls this contract's end blocker. That means, a tgrade chain upgrade proposal.

No need to upgrade the chain. When when.a contract is promoted to "privileged" (via gov proposal), a callback to the contract is sent to let it register for chain permissions (end blocker in this case).

Release 0.14 of tgrade-contracts

The repo was tagged 3 days ago. ( https://github.com/confio/poe-contracts/releases/tag/v0.14.0) do you mean v0.15 ?

@maurolacy
Copy link
Contributor

maurolacy commented Sep 16, 2022

Modify tgrade so that it calls this contract's end blocker. That means, a tgrade chain upgrade proposal.

No need to upgrade the chain. When when.a contract is promoted to "privileged" (via gov proposal), a callback to the contract is sent to let it register for chain permissions (end blocker in this case).

Nice! Didn't knew that.

Release 0.14 of tgrade-contracts

The repo was tagged 3 days ago. ( https://github.com/confio/poe-contracts/releases/tag/v0.14.0) do you mean v0.15 ?

tc_payments is part of tgrade-contracts, not poe-contracts. This requires a new release of tgrade-contracts.

In fact it will be good to release a new poe-contracts as well, just to update cw and cw-plus dependencies to latest.

@maurolacy
Copy link
Contributor

maurolacy commented Sep 20, 2022

The only problem is that that gov proposal (PromoteToPrivilegedContract) is currently unimplemented in the validator voting contract (confio/poe-contracts#158).

Will implement that, and we would finally have a route for storing, instantiating, promoting and wiring the payments contract.

@daniellarita
Copy link

Ok thanks. So it looks like there isn't anything that needs to be done on the blockchain side.

@maurolacy have you had a chance to implement PromoteToPrivilegedContract?

@daniellarita daniellarita self-assigned this Oct 5, 2022
@maurolacy
Copy link
Contributor

maurolacy commented Oct 5, 2022

Yes, this is already done (see confio/poe-contracts#188).

In fact the validator-voting contract with these changes is already deployed and migrated. See proposal number 8 in tgrade mainnet.

@maurolacy
Copy link
Contributor

maurolacy commented Oct 5, 2022

See the following slab doc for detailed progress / data related to this: https://confio.slab.com/posts/tgrade-tc-payments-deployment-on-mainnet-j8k6iz27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants