Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datacube-compute #28143

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Nov 8, 2024

A library with fast implementations of algorithms for processing satellite images! Repo at https://github.com/auspatious/datacube-compute

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

A library with fast implementations of algorithms for processing satellite images! Repo at https://github.com/auspatious/datacube-compute
Copy link

github-actions bot commented Nov 8, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 8, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/datacube-compute/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/datacube-compute/recipe.yaml:

Silence conda-forge linter messag: `The top level meta key schema_version is unexpected`
@weiji14
Copy link
Member Author

weiji14 commented Nov 8, 2024

Getting this error at https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1074934&view=logs&j=4cabe686-70ae-553a-7fd0-310379f2cbac&t=6a4fc7c9-c31a-5115-eff9-6479d72b69ff&l=904:

 │ │   LookupError: setuptools-scm was unable to detect version for $SRC_DIR.
 │ │   Make sure you're either building from a fully intact git repository or PyPI tarballs. Most other sources (such as GitHub's tarballs, a git checkout without the .git folder) don't contain the necessary metadata and will not work.
 │ │   For example, if you're using pip, instead of https://github.com/user/proj/archive/master.zip use git+https://github.com/user/proj.git#egg=proj
 │ │   error: subprocess-exited-with-error

Might need to patch how setuptools_scm is used upstream? Looks like auspatious/datacube-compute@028bd6c didn't quite cut it.

Edit: Oh wait, forgot about using SETUPTOOLS_SCM_PRETEND_VERSION - https://conda-forge.org/docs/maintainer/knowledge_base/#using-setuptools_scm

Comment on lines 53 to 54
recipe-maintainers:
- weiji14
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexgleith, ok if I put you down as a conda-forge recipe maintainer for datacube-compute (need a yes/no answer)?

Suggested change
recipe-maintainers:
- weiji14
recipe-maintainers:
- alexgleith
- weiji14

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Comment on lines +17 to +18
- SETUPTOOLS_SCM_PRETEND_VERSION=${{ version }} ${{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
skip: win
Copy link
Member Author

@weiji14 weiji14 Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't quite figured out the syntax to set an environment variable after looking at https://github.com/conda/ceps/blob/main/cep-0014.md#script-section (see attempt at 2f2c4df), so skipping Windows builds for now to workaround the SyntaxError.

@weiji14 weiji14 marked this pull request as ready for review November 8, 2024 06:05
@weiji14
Copy link
Member Author

weiji14 commented Nov 8, 2024

@conda-forge/help-rust @conda-forge/help-python, ready for review!

The linter is complaining that a c-compiler is needed, though I'm not sure if that is needed for a Rust (with Python bindings) package?

number: 0
script:
- cargo-bundle-licenses --format yaml --output THIRDPARTY.yml
- SETUPTOOLS_SCM_PRETEND_VERSION=${{ version }} ${{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For windows support

Suggested change
- SETUPTOOLS_SCM_PRETEND_VERSION=${{ version }} ${{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
- set SETUPTOOLS_SCM_PRETEND_VERSION=${{ version }} # [win]
- export SETUPTOOLS_SCM_PRETEND_VERSION=${{ version }} # [unix]
- ${{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants