Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up feedstocks still using conda-forge-ci-setup=3 #2282

Open
7 of 11 tasks
h-vetinari opened this issue Sep 1, 2024 · 6 comments
Open
7 of 11 tasks

Clean up feedstocks still using conda-forge-ci-setup=3 #2282

h-vetinari opened this issue Sep 1, 2024 · 6 comments

Comments

@h-vetinari
Copy link
Member

h-vetinari commented Sep 1, 2024

I noticed this in pytorch, and according to a search for this, we have around 10 feedstocks that are currently affected.

The problem with this is that using such an old ci-setup forces a very old conda-build, which is - pretty much by sheer luck - just barely new enough to correctly handle {{ stdlib("c") }}, which we need to avoid creating packages with incorrect metadata on osx/linux.

There are many other relevant changes that should make us retry to make these feedstocks use up-to-date build tools (some may still need to keep pinning lief due to various issues, but aside from a performance regression on osx, lief 0.14 should have fixed most things).

@Krande
Copy link

Krande commented Sep 1, 2024

@h-vetinari Okay, so all we need to do is to remove the remote_ci_setup entries and check to see if all goes well?

We are currently preparing a new release of ifcopenshell in conda-forge/ifcopenshell-feedstock#54. So I will try to make the changes there to see if that goes well.

Here's what we have. I remember pinning py-lief was necessary way back when due to the osx builds ran out of time. Changing the py-lief version at the time fixed it. Hopefully this is gone now.

Here's the remote_ci_setup in ifcopenshell

remote_ci_setup:
- conda-forge-ci-setup=3
- py-lief>=0.12.3

Krande added a commit to regro-cf-autotick-bot/ifcopenshell-feedstock that referenced this issue Sep 1, 2024
@Tobias-Fischer
Copy link

pcl, orocos-kdl, libignition-common all done

@Krande
Copy link

Krande commented Sep 2, 2024

@h-vetinari ifcopenshell is updated with the outdated configs removed.

@bollwyvl
Copy link
Contributor

bollwyvl commented Sep 2, 2024

tlsh is fixed (well, building)... I could probably use an assist on conda-forge/atheris-feedstock#16 (my c++ chops are non-existent):

src/native/counters.cc:26:6: error: variable or field '__sanitizer_cov_8bit_counters_init' declared void
   26 | void __sanitizer_cov_8bit_counters_init(uint8_t* start, uint8_t* stop);
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/native/counters.cc:26:41: error: 'uint8_t' was not declared in this scope
   26 | void __sanitizer_cov_8bit_counters_init(uint8_t* start, uint8_t* stop);
      |                                         ^~~~~~~
src/native/counters.cc:24:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
   23 | #include "macros.h"
  +++ |+#include <cstdint>

@Tobias-Fischer
Copy link

@bollwyvl: this patch should fix it: https://patch-diff.githubusercontent.com/raw/google/atheris/pull/91.patch

@bollwyvl
Copy link
Contributor

bollwyvl commented Sep 2, 2024

Thanks! Still seeing some OSX issues on atheris (but not missing libfuzzer, which was happening previously)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants