Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropping setuptools and wheel deps from pip #2252

Open
5 of 7 tasks
beckermr opened this issue Jul 31, 2024 · 5 comments
Open
5 of 7 tasks

dropping setuptools and wheel deps from pip #2252

beckermr opened this issue Jul 31, 2024 · 5 comments

Comments

@beckermr
Copy link
Member

beckermr commented Jul 31, 2024

In the new packaging scheme for python, pip no longer has setuptools and wheel as dependencies. Many of conda-forge's recipes rely on this transitive dependence (roughly ~20% according to this comment). Further, external users of pip also rely on this currently (see, e.g., pytorch). We'd like to move away from this in order to treat setuptools and wheel more consistently with respect to other build backends like flit, hatchling, etc.

To do this, we have arrived at the following transition plan, pulled from the original issue:

cc @conda-forge/pip @conda-forge/core for comments

closes conda-forge/pip-feedstock#124

@isuruf
Copy link
Member

isuruf commented Jul 31, 2024

I think we should make a pip package that drops wheel and setuptools for python>=3.13, but keep them for python<3.13 at the beginning. Then drop wheel and setuptools for python<3.13 after the 3.13 migrator is done.

@beckermr
Copy link
Member Author

I think we should make a pip package that drops wheel and setuptools for python>=3.13, but keep them for python<3.13 at the beginning. Then drop wheel and setuptools for python<3.13 after the 3.13 migrator is done.

SGTM! I have adjusted the text above.

@theAeon
Copy link

theAeon commented Aug 30, 2024

There wouldn't happen to be a way to silence the linter on this issue? https://github.com/conda-forge/pdm-backend-feedstock/ is its own build backend and as such works fine absent setuptools/wheel but still trips the warning on every PR.

@beckermr
Copy link
Member Author

We can add an allow list in the linter.

@theAeon
Copy link

theAeon commented Aug 30, 2024

That would be amazing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants