Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge cubano-webdriver-manager into cubano-webdriver #84

Open
nigelcharman opened this issue Sep 1, 2018 · 1 comment
Open

Merge cubano-webdriver-manager into cubano-webdriver #84

nigelcharman opened this issue Sep 1, 2018 · 1 comment

Comments

@nigelcharman
Copy link
Member

From @andrew-sumner:

I’d still like to merge Cubano-webdriver-manger into Cubano-webdriver now that the licencing is resolved, we had discussed this some time ago but I cannot remember what we decided.

@nigelcharman
Copy link
Member Author

My response:

Probably makes sense.

The alternative, looking ahead to Java 9 and modules, would be to view cubano-webdriver as a service interface with cubano-webdriver-manager as a service implementation. We'd then want the SauceLabs and BrowserStack classes to be in a different module too.

I'd be happy to merge them all into one for now, and then tackle how to package in Java 9 at a later date. What we might want to think about now, would be to use different packages for the implementations to keep it cleaner when we do split them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant