You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ReportLogger should be moved from CubanoDemoFixture to ConcordionBase and replace Logger. Should it have a getter as instead of being a protected field?
The text was updated successfully, but these errors were encountered:
Using a protected field is a fairly common practice.
A method would allow you to change the implementation, assuming Logger was an interface - eg. you wanted to return a different subclass, or a logger with a name different from the class name, based on some context that was passed in to the getLogger method?
I'm tempted to leave as a protected field, unless you think we might want different implementations to be returned?
Email from @andrew-sumner:
The text was updated successfully, but these errors were encountered: