Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReportLogger rather than Logger #82

Open
nigelcharman opened this issue Sep 1, 2018 · 1 comment
Open

Use ReportLogger rather than Logger #82

nigelcharman opened this issue Sep 1, 2018 · 1 comment

Comments

@nigelcharman
Copy link
Member

Email from @andrew-sumner:

ReportLogger should be moved from CubanoDemoFixture to ConcordionBase and replace Logger. Should it have a getter as instead of being a protected field?

@nigelcharman
Copy link
Member Author

My response:

Using a protected field is a fairly common practice.

A method would allow you to change the implementation, assuming Logger was an interface - eg. you wanted to return a different subclass, or a logger with a name different from the class name, based on some context that was passed in to the getLogger method?

I'm tempted to leave as a protected field, unless you think we might want different implementations to be returned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant