Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define CSS ordering with dependencies and locals #29

Closed
jonathanong opened this issue Dec 18, 2013 · 2 comments
Closed

define CSS ordering with dependencies and locals #29

jonathanong opened this issue Dec 18, 2013 · 2 comments
Labels

Comments

@jonathanong
Copy link
Contributor

componentjs/builder.js#109

@jonathanong
Copy link
Contributor Author

the way the builder works right now is recursively find all the deps in order of 1) dependencies 2) locals 3) component.json scripts, styles, etc. thus, dependencies' files are interleaved between local components' files.

i think dependencies' files should always be above any local components'. one cool thing is that we could just bundle all the dependencies together in a single build and have all the locals in a separate build.

my reasoning is that any local CSS should override any dependencies' CSS, regardless if its a direct dependency.

@ianstormtaylor
Copy link
Contributor

+1 to locals being after deps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants